Add support for JSX dev runtime #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
wooorm
reviewed
Sep 6, 2022
| // @ts-expect-error Acorn nodes are assignable to ESTree nodes. | ||
| Parser.extend(acornJsx()).parse( | ||
| doc.replace(/'name'/, "'jsx (estree-util-build-jsx, automatic)'"), | ||
| {sourceType: 'module', ecmaVersion: 2021} |
Member
There was a problem hiding this comment.
This might error (it just did for me on the above ones, see the ts-ignore for more info
Member
There was a problem hiding this comment.
oh it passes, weird 🤷♂️ well nvm then
Member
Author
There was a problem hiding this comment.
Yeah I had to resolve some merge conflicts here. Not sure what happened upstream.
ChristianMurphy
approved these changes
Sep 6, 2022
wooorm
approved these changes
Sep 8, 2022
wooorm
added
🦋 type/enhancement
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks, released in 3.1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This adds support for the JSX automatic development runtime.