Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

silentworks
Copy link
Collaborator

What kind of change does this PR introduce?

Allow developers to supply their own httpx client

What is the current behavior?

Httpx client isn't very configurable and has limited options available for the developer

What is the new behavior?

Httpx client can now be configured by the developer and be supplied to the storage library

Additional context

Add any other context or screenshots.

@silentworks silentworks requested a review from grdsdev May 10, 2025 08:29
@coveralls
Copy link

coveralls commented May 10, 2025

Pull Request Test Coverage Report for Build 15702426998

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 45 of 49 (91.84%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 96.645%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage3/_async/client.py 13 15 86.67%
storage3/_sync/client.py 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
storage3/init.py 3 84.21%
Totals Coverage Status
Change from base Build 15702295064: -1.0%
Covered Lines: 605
Relevant Lines: 626

💛 - Coveralls

@silentworks silentworks requested a review from grdsdev May 15, 2025 12:41
fix: add deprecation warnings for SyncClient
test: update to use Client instead of SyncClient
@silentworks silentworks merged commit b04be02 into main Jun 17, 2025
12 checks passed
@silentworks silentworks deleted the silentworks/httpx-dependency-injection branch June 17, 2025 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants