Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

silentworks
Copy link
Collaborator

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

.exists method is raising an exception when a file is not found

What is the new behavior?

.exists method is returning false when a file is not found

Additional context

Add any other context or screenshots.

@silentworks silentworks requested a review from grdsdev January 18, 2025 23:45
@silentworks silentworks linked an issue Jan 18, 2025 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12848405494

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 83.709%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage3/_async/file_api.py 3 5 60.0%
storage3/_sync/file_api.py 3 5 60.0%
Totals Coverage Status
Change from base Build 12659581505: -0.5%
Covered Lines: 483
Relevant Lines: 577

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12848405494

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 83.709%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage3/_async/file_api.py 3 5 60.0%
storage3/_sync/file_api.py 3 5 60.0%
Totals Coverage Status
Change from base Build 12659581505: -0.5%
Covered Lines: 483
Relevant Lines: 577

💛 - Coveralls

@juancarlospaco
Copy link
Contributor

LGTM

@silentworks silentworks enabled auto-merge (squash) January 22, 2025 21:41
@silentworks silentworks merged commit cc37894 into main Jan 22, 2025
11 checks passed
@silentworks silentworks deleted the silentworks/fix-exists-method branch January 22, 2025 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exists method throws if file does not exist

4 participants