This repository was archived by the owner on Oct 10, 2025. It is now read-only.
fix: generatePKCEChallenge should use btoa
#1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/revert-btoa-thing
branch
from
ab52602 to
52d788e
Compare
kangmingtay
approved these changes
Mar 24, 2025
hf
pushed a commit
that referenced
this pull request
Mar 24, 2025
🤖 I have created a release *beep* *boop* --- ## [2.69.1](v2.69.0...v2.69.1) (2025-03-24) ### Bug Fixes * `generatePKCEChallenge` should use btoa ([#1044](#1044)) ([c06fafb](c06fafb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mandarini
pushed a commit
to supabase/supabase-js
that referenced
this pull request
Oct 2, 2025
🤖 I have created a release *beep* *boop* --- ## [2.69.1](supabase/auth-js@v2.69.0...v2.69.1) (2025-03-24) ### Bug Fixes * `generatePKCEChallenge` should use btoa ([#1044](supabase/auth-js#1044)) ([15d308e](supabase/auth-js@15d308e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringToBase64URLexpects a unicode string not a data string.