Retrieve the latest release using the HTTP client #1544
Conversation
skitt
requested review from
Jaanki,
Oats87,
aswinsuryan,
dfarrell07,
maayanf24,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1544/skitt/drop-go-github-dep |
skitt
force-pushed
the
drop-go-github-dep
branch
2 times, most recently
from
6d26776 to
f685b9d
Compare
| if err == nil { | ||
| upgradeSubctlVersion = *latestRelease.TagName | ||
| tag, err := retrieveLatestReleaseTag() | ||
| if err != nil { |
There was a problem hiding this comment.
We should at least log the error instead of silencing it. Also shouldn't this be:
| if err != nil { | |
| if err == nil { |
There was a problem hiding this comment.
Oops, yes, it should be! We didn’t log the error in the past, and where should we log it? This is in subctl, so apart from the screen there isn’t anywhere to log it. The error is unlikely to be user-actionable so this would probably only confuse people...
There was a problem hiding this comment.
We can log it to the status as a warning. It may not be actionable but it would be informational, in case something else goes wrong as a side-effect that might provide a clue. I don't think it's best practice to ignore errors.
This avoids a dependency on go-github, which drops a few transitive dependencies that were only used to retrieve the latest release from the GitHub API. This helps our dependency tree... Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
drop-go-github-dep
branch
from
f685b9d to
4d5305e
Compare
4 participants
This avoids a dependency on go-github, which drops a few transitive dependencies that were only used to retrieve the latest release from the GitHub API. This helps our dependency tree...