bench: refactor random value generation

PR-URL: #5465

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Karan Anand <[email protected]>

Author: saurabhraghuvanshii

lib/node_modules/@stdlib/math/base/special/binet/benchmark/benchmark.js

@@ -21,8 +21,7 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
-var floor = require( '@stdlib/math/base/special/floor' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pkg = require( './../package.json' ).name;
 var binet = require( './../lib' );
@@ -35,10 +34,11 @@ bench( pkg, function benchmark( b ) {
 	var y;
 	var i;
 
+	x = discreteUniform( 100, 0, 79 );
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = floor( randu()*79.0 );
-		y = binet( x );
+		y = binet( x[ i%x.length ] );
 		if ( isnan( y ) ) {
 			b.fail( 'should not return NaN' );
 		}

lib/node_modules/@stdlib/math/base/special/binet/benchmark/benchmark.native.js

@@ -22,8 +22,7 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
-var floor = require( '@stdlib/math/base/special/floor' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
@@ -44,10 +43,11 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	var y;
 	var i;
 
+	x = discreteUniform( 100, 0, 79 );
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = floor( randu() * 79.0 );
-		y = binet( x );
+		y = binet( x[ i%x.length ] );
 		if ( isnan( y ) ) {
 			b.fail( 'should not return NaN' );
 		}

lib/node_modules/@stdlib/math/base/special/binet/benchmark/c/benchmark.c

@@ -16,6 +16,7 @@
 * limitations under the License.
 */
 
+#include "stdlib/math/base/special/binet.h"
 #include <stdlib.h>
 #include <stdio.h>
 #include <math.h>
@@ -99,16 +100,19 @@ double binet( double x ) {
 * @return elapsed time in seconds
 */
 static double benchmark( void ) {
+	double x[ 100 ];
 	double elapsed;
 	double t;
-	double x;
 	double y;
 	int i;
 
+	for ( i = 0; i < 100; i++ ) {
+		x[ i ] = floor( 79.0*rand_double() );
+	}
+
 	t = tic();
 	for ( i = 0; i < ITERATIONS; i++ ) {
-		x = floor( 79.0*rand_double() );
-		y = binet( x );
+		y = stdlib_base_binet( x[ i%100 ] );
 		if ( y < 0 ) {
 			printf( "should return a nonnegative number\n" );
 			break;

lib/node_modules/@stdlib/math/base/special/binet/benchmark/c/native/benchmark.c

@@ -90,16 +90,19 @@ static double rand_double( void ) {
 * @return elapsed time in seconds
 */
 static double benchmark( void ) {
+	double x[ 100 ];
 	double elapsed;
-	double x;
 	double y;
 	double t;
 	int i;
 
+	for ( i = 0; i < 100; i++ ) {
+		x[ i ] = floor( 79.0*rand_double() );
+	}
+
 	t = tic();
 	for ( i = 0; i < ITERATIONS; i++ ) {
-		x = floor( 79.0 * rand_double() );
-		y = stdlib_base_binet( x );
+		y = stdlib_base_binet( x[ i%100 ] );
 		if ( y != y ) {
 			printf( "should not return NaN\n" );
 			break;

lib/node_modules/@stdlib/math/base/special/binet/test/test.js

@@ -41,19 +41,19 @@ tape( 'main export is a function', function test( t ) {
 
 tape( 'if provided `NaN`, the function returns `NaN`', function test( t ) {
 	var v = binet( NaN );
-	t.strictEqual( isnan( v ), true, 'returns NaN when provided a NaN' );
+	t.strictEqual( isnan( v ), true, 'returns expected value' );
 	t.end();
 });
 
 tape( 'if provided `+infinity`, the function returns `NaN`', function test( t ) {
 	var v = binet( PINF );
-	t.strictEqual( isnan( v ), true, 'returns NaN' );
+	t.strictEqual( isnan( v ), true, 'returns expected value' );
 	t.end();
 });
 
 tape( 'if provided `-infinity`, the function returns `NaN`', function test( t ) {
 	var v = binet( NINF );
-	t.strictEqual( isnan( v ), true, 'returns NaN' );
+	t.strictEqual( isnan( v ), true, 'returns expected value' );
 	t.end();
 });
 

lib/node_modules/@stdlib/math/base/special/binomcoef/benchmark/benchmark.js

@@ -34,15 +34,13 @@ bench( pkg, function benchmark( b ) {
 	var y;
 	var z;
 	var i;
-	var j;
 
 	x = discreteUniform( 100, 20, 70 );
-	y = discreteUniform( x.length, 0, 20 );
+	y = discreteUniform( 100, 0, 20 );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		j = i % x.length;
-		z = binomcoef( x[ j ], y[ j ] );
+		z = binomcoef( x[ i%x.length ], y[ i%y.length ] );
 		if ( isnan( z ) ) {
 			b.fail( 'should not return NaN' );
 		}

lib/node_modules/@stdlib/math/base/special/binomcoef/benchmark/benchmark.native.js

@@ -43,15 +43,13 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	var y;
 	var z;
 	var i;
-	var j;
 
 	x = discreteUniform( 100, 20, 70 );
-	y = discreteUniform( x.length, 0, 20 );
+	y = discreteUniform( 100, 0, 20 );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		j = i % x.length;
-		z = binomcoef( x[ j ], y[ j ] );
+		z = binomcoef( x[ i%x.length ], y[ i%y.length ] );
 		if ( isnan( z ) ) {
 			b.fail( 'should not return NaN' );
 		}

lib/node_modules/@stdlib/math/base/special/binomcoef/benchmark/c/native/benchmark.c

@@ -90,18 +90,21 @@ static double rand_double( void ) {
 * @return elapsed time in seconds
 */
 static double benchmark( void ) {
+	int64_t n[ 100 ];
+	int64_t k[ 100 ];
 	double elapsed;
-	int64_t n;
-	int64_t k;
 	double y;
 	double t;
 	int i;
 
+	for ( i = 0; i < 100; i++ ) {
+		n[ i ] = (int64_t)round( 500.0 * rand_double() );
+		k[ i ] = (int64_t)round( 500.0 * rand_double() );
+	}
+
 	t = tic();
 	for ( i = 0; i < ITERATIONS; i++ ) {
-		n = (int64_t)round( 500.0 * rand_double() );
-		k = (int64_t)round( 500.0 * rand_double() );
-		y = stdlib_base_binomcoef( n, k );
+		y = stdlib_base_binomcoef( n[ i%100 ], k[ i%100 ] );
 		if ( y != y ) {
 			printf( "should not return NaN\n" );
 			break;

lib/node_modules/@stdlib/math/base/special/binomcoef/test/test.js

@@ -43,10 +43,10 @@ tape( 'main export is a function', function test( t ) {
 
 tape( 'the function returns `NaN` if provided `NaN` for any parameter', function test( t ) {
 	var v = binomcoef( 3, NaN );
-	t.strictEqual( isnan( v ), true, 'returns NaN' );
+	t.strictEqual( isnan( v ), true, 'returns expected value' );
 
 	v = binomcoef( NaN, 2 );
-	t.strictEqual( isnan( v ), true, 'returns NaN' );
+	t.strictEqual( isnan( v ), true, 'returns expected value' );
 
 	t.end();
 });
@@ -101,7 +101,7 @@ tape( 'the function returns `NaN` if the `n` value is not an integer', function
 	];
 
 	for ( i = 0; i < values.length; i++ ) {
-		t.strictEqual( isnan( binomcoef( values[i], 2 ) ), true, 'returns NaN when provided '+values[i] );
+		t.strictEqual( isnan( binomcoef( values[i], 2 ) ), true, 'returns expected value when provided '+values[i] );
 	}
 	t.end();
 });
@@ -122,7 +122,7 @@ tape( 'the function returns `NaN` if the `k` value is not an integer', function
 	];
 
 	for ( i = 0; i < values.length; i++ ) {
-		t.strictEqual( isnan( binomcoef( 2, values[i] ) ), true, 'returns NaN when provided '+values[i] );
+		t.strictEqual( isnan( binomcoef( 2, values[i] ) ), true, 'returns expected value when provided '+values[i] );
 	}
 	t.end();
 });

lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.js

@@ -21,7 +21,7 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/array/uniform' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pkg = require( './../package.json' ).name;
 var boxcox = require( './../lib' );
@@ -35,11 +35,12 @@ bench( pkg, function benchmark( b ) {
 	var r;
 	var i;
 
+	x = uniform( 100, 1.0, 11.0 );
+	y = uniform( 100, 1.0, 11.0 );
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*10.0 ) + 1.0;
-		y = ( randu()*10.0 ) + 1.0;
-		r = boxcox( x, y );
+		r = boxcox( x[ i%x.length ], y[ i%y.length ] );
 		if ( isnan( r ) ) {
 			b.fail( 'should not return NaN' );
 		}