Skip to content

Add sat cycle #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2024
Merged

Add sat cycle #6

merged 3 commits into from
May 13, 2024

Conversation

@emmanuelmathot
Copy link
Member

This PR adds the information about repeat cycle of the satellite

@emmanuelmathot
Add sat cycle
59c4519 
This PR adds the information about repeat cycle of the satellite
m-mohr
m-mohr reviewed Apr 15, 2024
View reviewed changes
m-mohr
m-mohr requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. It took me two cycles to understand this, so maybe a bit more explanations would be good. Or a link to a page that explains cycles, rel orbits etc?

Requested required changes:

  • Add a Changelog entry
  • Remove vscode file

@emmanuelmathot emmanuelmathot requested a review from m-mohr April 16, 2024 07:09
m-mohr
m-mohr approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmanuelmathot emmanuelmathot merged commit 9b9a8b8 into main May 13, 2024
@m-mohr m-mohr deleted the cycle branch May 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-mohr m-mohr m-mohr approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmanuelmathot @m-mohr