Use plain for-loop over foreach(range() ..)

staabm · staabm · commit 5b45ec806a26 · 2025-11-10T08:51:46.000+01:00
diff --git a/src/Node/File.php b/src/Node/File.php
@@ -11,7 +11,6 @@
 
 use function array_filter;
 use function count;
-use function range;
 use SebastianBergmann\CodeCoverage\CodeCoverage;
 use SebastianBergmann\CodeCoverage\StaticAnalysis\AnalysisResult;
 use SebastianBergmann\CodeCoverage\StaticAnalysis\Class_;
@@ -372,15 +371,15 @@ public function numberOfTestedFunctions(): int
      */
     private function calculateStatistics(array $classes, array $traits, array $functions): void
     {
-        foreach (range(1, $this->linesOfCode->linesOfCode()) as $lineNumber) {
+        for ($lineNumber = 1; $lineNumber <= $this->linesOfCode->linesOfCode(); $lineNumber++) {
             $this->codeUnitsByLine[$lineNumber] = [];
         }
 
         $this->processClasses($classes);
         $this->processTraits($traits);
         $this->processFunctions($functions);
 
-        foreach (range(1, $this->linesOfCode->linesOfCode()) as $lineNumber) {
+        for ($lineNumber = 1; $lineNumber <= $this->linesOfCode->linesOfCode(); $lineNumber++) {
             if (isset($this->lineCoverageData[$lineNumber])) {
                 foreach ($this->codeUnitsByLine[$lineNumber] as &$codeUnit) {
                     $codeUnit['executableLines']++;
@@ -511,7 +510,7 @@ private function processClasses(array $classes): void
                 $this->numExecutablePaths    += $methodData['executablePaths'];
                 $this->numExecutedPaths      += $methodData['executedPaths'];
 
-                foreach (range($method->startLine(), $method->endLine()) as $lineNumber) {
+                for ($lineNumber = $method->startLine(); $lineNumber <= $method->endLine(); $lineNumber++) {
                     $this->codeUnitsByLine[$lineNumber] = [
                         &$this->classes[$className],
                         &$this->classes[$className]['methods'][$methodName],
@@ -560,7 +559,7 @@ private function processTraits(array $traits): void
                 $this->numExecutablePaths    += $methodData['executablePaths'];
                 $this->numExecutedPaths      += $methodData['executedPaths'];
 
-                foreach (range($method->startLine(), $method->endLine()) as $lineNumber) {
+                for ($lineNumber = $method->startLine(); $lineNumber <= $method->endLine(); $lineNumber++) {
                     $this->codeUnitsByLine[$lineNumber] = [
                         &$this->traits[$traitName],
                         &$this->traits[$traitName]['methods'][$methodName],
@@ -596,7 +595,7 @@ private function processFunctions(array $functions): void
                 'link'               => $link . $function->startLine(),
             ];
 
-            foreach (range($function->startLine(), $function->endLine()) as $lineNumber) {
+            for ($lineNumber = $function->startLine(); $lineNumber <= $function->endLine(); $lineNumber++) {
                 $this->codeUnitsByLine[$lineNumber] = [&$this->functions[$functionName]];
             }
 
diff --git a/src/Report/Clover.php b/src/Report/Clover.php
@@ -13,7 +13,6 @@
 use function is_string;
 use function ksort;
 use function max;
-use function range;
 use function time;
 use DOMDocument;
 use SebastianBergmann\CodeCoverage\CodeCoverage;
@@ -95,7 +94,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
 
                     $methodCount = 0;
 
-                    foreach (range($method['startLine'], $method['endLine']) as $line) {
+                    for ($line = $method['startLine']; $line <= $method['endLine']; $line++) {
                         if (isset($coverageData[$line])) {
                             $methodCount = max($methodCount, count($coverageData[$line]));
                         }
diff --git a/src/Report/Cobertura.php b/src/Report/Cobertura.php
@@ -13,7 +13,6 @@
 use function basename;
 use function count;
 use function preg_match;
-use function range;
 use function str_replace;
 use function time;
 use DOMImplementation;
@@ -170,7 +169,7 @@ public function process(CodeCoverage $coverage, ?string $target = null): string
 
                     $methodElement->appendChild($methodLinesElement);
 
-                    foreach (range($method['startLine'], $method['endLine']) as $line) {
+                    for ($line = $method['startLine']; $line <= $method['endLine']; $line++) {
                         if (!isset($coverageData[$line])) {
                             continue;
                         }
@@ -251,7 +250,7 @@ public function process(CodeCoverage $coverage, ?string $target = null): string
 
                 $methodElement->appendChild($methodLinesElement);
 
-                foreach (range($function['startLine'], $function['endLine']) as $line) {
+                for ($line = $function['startLine']; $line <= $function['endLine']; $line++) {
                     if (!isset($coverageData[$line])) {
                         continue;
                     }
diff --git a/src/Report/Html/Renderer/File.php b/src/Report/Html/Renderer/File.php
@@ -609,7 +609,7 @@ private function renderSourceWithBranchCoverage(FileNode $node): string
 
         foreach ($functionCoverageData as $method) {
             foreach ($method['branches'] as $branch) {
-                foreach (range($branch['line_start'], $branch['line_end']) as $line) {
+                for ($line = $branch['line_start']; $line <= $branch['line_end']; $line++) {
                     if (!isset($lineData[$line])) { // blank line at end of file is sometimes included here
                         continue;
                     }
@@ -696,7 +696,7 @@ private function renderSourceWithPathCoverage(FileNode $node): string
         foreach ($functionCoverageData as $method) {
             foreach ($method['paths'] as $pathId => $path) {
                 foreach ($path['path'] as $branchTaken) {
-                    foreach (range($method['branches'][$branchTaken]['line_start'], $method['branches'][$branchTaken]['line_end']) as $line) {
+                    for ($line = $method['branches'][$branchTaken]['line_start']; $line <= $method['branches'][$branchTaken]['line_end']; $line++) {
                         if (!isset($lineData[$line])) {
                             continue;
                         }
diff --git a/src/Report/OpenClover.php b/src/Report/OpenClover.php
@@ -15,7 +15,6 @@
 use function is_string;
 use function ksort;
 use function max;
-use function range;
 use function str_replace;
 use function time;
 use DOMDocument;
@@ -99,7 +98,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
 
                     $methodCount = 0;
 
-                    foreach (range($method['startLine'], $method['endLine']) as $line) {
+                    for ($line = $method['startLine']; $line <= $method['endLine']; $line++) {
                         if (isset($coverageData[$line])) {
                             $methodCount = max($methodCount, count($coverageData[$line]));
                         }
diff --git a/src/StaticAnalysis/Visitor/ExecutableLinesFindingVisitor.php b/src/StaticAnalysis/Visitor/ExecutableLinesFindingVisitor.php
@@ -18,7 +18,6 @@
 use function max;
 use function preg_match;
 use function preg_quote;
-use function range;
 use function reset;
 use function sprintf;
 use PhpParser\Node;
@@ -75,7 +74,7 @@ public function enterNode(Node $node): null
             $endLine   = $node->getEndLine() - 1;
 
             if ($startLine <= $endLine) {
-                foreach (range($startLine, $endLine) as $line) {
+                for ($line = $startLine; $line <= $endLine; $line++) {
                     unset($this->executableLinesGroupedByBranch[$line]);
                 }
             }
@@ -84,7 +83,7 @@ public function enterNode(Node $node): null
         }
 
         if ($node instanceof Node\Stmt\Interface_) {
-            foreach (range($node->getStartLine(), $node->getEndLine()) as $line) {
+            for ($line = $node->getStartLine(); $line <= $node->getEndLine(); $line++) {
                 $this->unsets[$line] = true;
             }
 
@@ -144,7 +143,7 @@ public function enterNode(Node $node): null
                 $unsets = [];
 
                 foreach ($node->getParams() as $param) {
-                    foreach (range($param->getStartLine(), $param->getEndLine()) as $line) {
+                    for ($line = $param->getStartLine(); $line <= $param->getEndLine(); $line++) {
                         $unsets[$line] = true;
                     }
                 }
@@ -162,7 +161,7 @@ public function enterNode(Node $node): null
                         continue;
                     }
 
-                    foreach (range($stmt->getStartLine(), $stmt->getEndLine()) as $line) {
+                    for ($line = $stmt->getStartLine(); $line <= $stmt->getEndLine(); $line++) {
                         unset($this->executableLinesGroupedByBranch[$line]);
 
                         if (
@@ -395,7 +394,7 @@ public function executableLinesGroupedByBranch(): array
 
     private function setLineBranch(int $start, int $end, int $branch): void
     {
-        foreach (range($start, $end) as $line) {
+        for ($line = $start; $line <= $end; $line++) {
             $this->executableLinesGroupedByBranch[$line] = $branch;
         }
     }
diff --git a/src/Target/MapBuilder.php b/src/Target/MapBuilder.php
@@ -111,7 +111,7 @@ public function build(Filter $filter, FileAnalyser $analyser): array
 
                 $this->process($functions, $function->namespacedName(), $file, $function->startLine(), $function->endLine());
 
-                foreach (range($function->startLine(), $function->endLine()) as $line) {
+                for ($line = $function->startLine(); $line <= $function->endLine(); $line++) {
                     $reverseLookup[$file . ':' . $line] = $function->namespacedName();
                 }
             }
@@ -202,7 +202,7 @@ private function processMethods(Class_|Trait_ $classOrTrait, string $file, array
 
             $this->process($methods, $methodName, $file, $method->startLine(), $method->endLine());
 
-            foreach (range($method->startLine(), $method->endLine()) as $line) {
+            for ($line = $method->startLine(); $line <= $method->endLine(); $line++) {
                 $reverseLookup[$file . ':' . $line] = $methodName;
             }
         }
@@ -221,7 +221,7 @@ private function processNamespace(array &$data, string $namespace, string $file,
     {
         $parts = explode('\\', $namespace);
 
-        foreach (range(1, count($parts)) as $i) {
+        for ($i = 1; $i <= count($parts); $i++) {
             $this->process($data, implode('\\', array_slice($parts, 0, $i)), $file, $startLine, $endLine);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`use function max;`
`19`	`19`	`use function preg_match;`
`20`	`20`	`use function preg_quote;`
`21`		`-use function range;`
`22`	`21`	`use function reset;`
`23`	`22`	`use function sprintf;`
`24`	`23`	`use PhpParser\Node;`
`@@ -75,7 +74,7 @@ public function enterNode(Node $node): null`
`75`	`74`	`$endLine = $node->getEndLine() - 1;`
`76`	`75`
`77`	`76`	`if ($startLine <= $endLine) {`
`78`		`- foreach (range($startLine, $endLine) as $line) {`
	`77`	`+ for ($line = $startLine; $line <= $endLine; $line++) {`
`79`	`78`	`unset($this->executableLinesGroupedByBranch[$line]);`
`80`	`79`	`}`
`81`	`80`	`}`
`@@ -84,7 +83,7 @@ public function enterNode(Node $node): null`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`if ($node instanceof Node\Stmt\Interface_) {`
`87`		`- foreach (range($node->getStartLine(), $node->getEndLine()) as $line) {`
	`86`	`+ for ($line = $node->getStartLine(); $line <= $node->getEndLine(); $line++) {`
`88`	`87`	`$this->unsets[$line] = true;`
`89`	`88`	`}`
`90`	`89`
`@@ -144,7 +143,7 @@ public function enterNode(Node $node): null`
`144`	`143`	`$unsets = [];`
`145`	`144`
`146`	`145`	`foreach ($node->getParams() as $param) {`
`147`		`- foreach (range($param->getStartLine(), $param->getEndLine()) as $line) {`
	`146`	`+ for ($line = $param->getStartLine(); $line <= $param->getEndLine(); $line++) {`
`148`	`147`	`$unsets[$line] = true;`
`149`	`148`	`}`
`150`	`149`	`}`
`@@ -162,7 +161,7 @@ public function enterNode(Node $node): null`
`162`	`161`	`continue;`
`163`	`162`	`}`
`164`	`163`
`165`		`- foreach (range($stmt->getStartLine(), $stmt->getEndLine()) as $line) {`
	`164`	`+ for ($line = $stmt->getStartLine(); $line <= $stmt->getEndLine(); $line++) {`
`166`	`165`	`unset($this->executableLinesGroupedByBranch[$line]);`
`167`	`166`
`168`	`167`	`if (`
`@@ -395,7 +394,7 @@ public function executableLinesGroupedByBranch(): array`
`395`	`394`
`396`	`395`	`private function setLineBranch(int $start, int $end, int $branch): void`
`397`	`396`	`{`
`398`		`- foreach (range($start, $end) as $line) {`
	`397`	`+ for ($line = $start; $line <= $end; $line++) {`
`399`	`398`	`$this->executableLinesGroupedByBranch[$line] = $branch;`
`400`	`399`	`}`
`401`	`400`	`}`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public function build(Filter $filter, FileAnalyser $analyser): array`
`111`	`111`
`112`	`112`	`$this->process($functions, $function->namespacedName(), $file, $function->startLine(), $function->endLine());`
`113`	`113`
`114`		`- foreach (range($function->startLine(), $function->endLine()) as $line) {`
	`114`	`+ for ($line = $function->startLine(); $line <= $function->endLine(); $line++) {`
`115`	`115`	`$reverseLookup[$file . ':' . $line] = $function->namespacedName();`
`116`	`116`	`}`
`117`	`117`	`}`
`@@ -202,7 +202,7 @@ private function processMethods(Class_\|Trait_ $classOrTrait, string $file, array`
`202`	`202`
`203`	`203`	`$this->process($methods, $methodName, $file, $method->startLine(), $method->endLine());`
`204`	`204`
`205`		`- foreach (range($method->startLine(), $method->endLine()) as $line) {`
	`205`	`+ for ($line = $method->startLine(); $line <= $method->endLine(); $line++) {`
`206`	`206`	`$reverseLookup[$file . ':' . $line] = $methodName;`
`207`	`207`	`}`
`208`	`208`	`}`
`@@ -221,7 +221,7 @@ private function processNamespace(array &$data, string $namespace, string $file,`
`221`	`221`	`{`
`222`	`222`	`$parts = explode('\\', $namespace);`
`223`	`223`
`224`		`- foreach (range(1, count($parts)) as $i) {`
	`224`	`+ for ($i = 1; $i <= count($parts); $i++) {`
`225`	`225`	`$this->process($data, implode('\\', array_slice($parts, 0, $i)), $file, $startLine, $endLine);`
`226`	`226`	`}`
`227`	`227`	`}`