project review

Author: bnasslahsen

springdoc-openapi-common/src/main/java/org/springdoc/api/AbstractOpenApiResource.java

@@ -83,6 +83,7 @@ public abstract class AbstractOpenApiResource {
 	private final SpringDocConfigProperties springDocConfigProperties;
 
 	private static final List<Class<?>> ADDITIONAL_REST_CONTROLLERS = new ArrayList<>();
+	private static final List<Class<?>> HIDDEN_REST_CONTROLLERS = new ArrayList<>();
 
 	private boolean computeDone;
 
@@ -113,6 +114,7 @@ protected synchronized OpenAPI getOpenApi() {
 					.flatMap(mapEl -> mapEl.entrySet().stream())
 					.filter(controller -> (AnnotationUtils.findAnnotation(controller.getValue().getClass(),
 							Hidden.class) == null))
+					.filter(controller -> !isHiddenRestControllers(controller.getValue().getClass()))
 					.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue, (a1, a2) -> a1));
 
 			Map<String, Object> findControllerAdvice = openAPIBuilder.getControllerAdviceMap();
@@ -358,6 +360,13 @@ public static void addRestControllers(Class<?>... classes) {
 		ADDITIONAL_REST_CONTROLLERS.addAll(Arrays.asList(classes));
 	}
 
+	public static void addHiddenRestControllers(Class<?>... classes) {
+		HIDDEN_REST_CONTROLLERS.addAll(Arrays.asList(classes));
+	}
+	protected boolean isHiddenRestControllers(Class<?> rawClass) {
+		return HIDDEN_REST_CONTROLLERS.stream().anyMatch(clazz -> clazz.isAssignableFrom(rawClass));
+	}
+
 	protected Set getDefaultAllowedHttpMethods() {
 		RequestMethod[] allowedRequestMethods = { RequestMethod.GET, RequestMethod.POST, RequestMethod.PUT, RequestMethod.PATCH, RequestMethod.DELETE, RequestMethod.OPTIONS, RequestMethod.HEAD };
 		return new HashSet<>(Arrays.asList(allowedRequestMethods));

springdoc-openapi-common/src/main/java/org/springdoc/core/GenericParameterBuilder.java

@@ -25,6 +25,7 @@
 import java.lang.reflect.Type;
 import java.lang.reflect.WildcardType;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -64,7 +65,6 @@ public class GenericParameterBuilder {
 
 	static {
 		FILE_TYPES.add(MultipartFile.class);
-		FILE_TYPES.add(FilePart.class);
 	}
 
 	public GenericParameterBuilder(LocalVariableTableParameterNameDiscoverer localSpringDocParameterNameDiscoverer, IgnoredParameterAnnotations ignoredParameterAnnotations) {
@@ -373,4 +373,8 @@ private JavaType constructType(Type type) {
 	public boolean isAnnotationToIgnore(java.lang.reflect.Parameter parameter) {
 		return ignoredParameterAnnotations.isAnnotationToIgnore(parameter);
 	}
+
+	public static void addFileType(Class<?>... classes) {
+		FILE_TYPES.addAll(Arrays.asList(classes));
+	}
 }

springdoc-openapi-common/src/main/java/org/springdoc/core/SwaggerUiConfigProperties.java

@@ -433,17 +433,12 @@ public int hashCode() {
 		}
 	}
 
-	static enum Direction {
+	enum Direction {
 		ASC,
 		DESC;
-
 		public boolean isAscending() {
 			return this.equals(ASC);
 		}
-
-		public boolean isDescending() {
-			return this.equals(DESC);
-		}
 	}
 
 	public Direction getGroupsOrder() {

springdoc-openapi-ui/src/test/java/test/org/springdoc/ui/app4/SpringDocApp4Test.java

@@ -18,7 +18,6 @@
 
 package test.org.springdoc.ui.app4;
 
-import java.util.ArrayList;
 import java.util.HashSet;
 
 import org.junit.jupiter.api.AfterEach;

springdoc-openapi-webflux-core/src/main/java/org/springdoc/core/RequestBuilder.java

@@ -24,14 +24,18 @@
 import org.springdoc.core.customizers.OperationCustomizer;
 import org.springdoc.core.customizers.ParameterCustomizer;
 
+import org.springframework.http.codec.multipart.FilePart;
 import org.springframework.http.server.reactive.ServerHttpRequest;
 import org.springframework.http.server.reactive.ServerHttpResponse;
 import org.springframework.web.server.ServerWebExchange;
 
+import static org.springdoc.core.GenericParameterBuilder.addFileType;
+
 public class RequestBuilder extends AbstractRequestBuilder {
 
 	static {
 		addResponseWrapperToIgnore(ServerWebExchange.class,ServerHttpRequest.class,ServerHttpResponse.class);
+		addFileType(FilePart.class);
 	}
 
 	public RequestBuilder(GenericParameterBuilder parameterBuilder, RequestBodyBuilder requestBodyBuilder,