Skip to content

Suggest replacing size() == 0 with isEmpty() for collection check #16428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Suggest replacing size() == 0 with isEmpty() for collection check #16428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/springframework/security/core/ComparableVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ public int getType() {

@Override
public boolean isNull() {
return (size() == 0);
return isEmpty();
}

void normalize() {
Expand All @@ -434,7 +434,7 @@ else if (!(lastItem instanceof ListItem)) {
@Override
public int compareTo(Item item) {
if (item == null) {
if (size() == 0) {
if (isEmpty()) {
return 0; // 1-0 = 1- (normalize) = 1
}
Item first = get(0);
Expand Down
Loading