Skip to content

Commit 18d6a55

Browse files
sbrannensbrannen
committed
Polishing and removal of "this." for method invocations
1 parent 99890b6 commit 18d6a55

File tree

37 files changed

+127
-135
lines changed

37 files changed

+127
-135
lines changed

‎spring-aop/src/testFixtures/java/org/springframework/aop/testfixture/advice/MethodCounter.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2023 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@
2424
import org.springframework.lang.Nullable;
2525

2626
/**
27-
* Abstract superclass for counting advices etc.
27+
* Abstract superclass for counting advice, etc.
2828
*
2929
* @author Rod Johnson
3030
* @author Chris Beams
@@ -62,7 +62,7 @@ public int getCalls() {
6262
*/
6363
@Override
6464
public boolean equals(@Nullable Object other) {
65-
return (other != null && other.getClass() == this.getClass());
65+
return (other != null && getClass() == other.getClass());
6666
}
6767

6868
@Override

‎spring-beans/src/test/java/org/springframework/beans/factory/FactoryBeanLookupTests.java‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -33,13 +33,14 @@
3333
* @author Chris Beams
3434
*/
3535
class FactoryBeanLookupTests {
36-
private BeanFactory beanFactory;
36+
37+
private final BeanFactory beanFactory = new DefaultListableBeanFactory();
38+
3739

3840
@BeforeEach
3941
void setUp() {
40-
beanFactory = new DefaultListableBeanFactory();
4142
new XmlBeanDefinitionReader((BeanDefinitionRegistry) beanFactory).loadBeanDefinitions(
42-
new ClassPathResource("FactoryBeanLookupTests-context.xml", this.getClass()));
43+
new ClassPathResource("FactoryBeanLookupTests-context.xml", getClass()));
4344
}
4445

4546
@Test
@@ -71,6 +72,7 @@ void factoryBeanObjectLookupByNameAndType() {
7172
Foo foo = beanFactory.getBean("fooFactory", Foo.class);
7273
assertThat(foo).isNotNull();
7374
}
75+
7476
}
7577

7678
class FooFactoryBean extends AbstractFactoryBean<Foo> {

‎spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2453,7 +2453,7 @@ void genericsBasedConstructorInjection() {
24532453
}
24542454

24552455
@Test
2456-
@SuppressWarnings("unchecked")
2456+
@SuppressWarnings({ "unchecked", "rawtypes" })
24572457
void genericsBasedConstructorInjectionWithNonTypedTarget() {
24582458
RootBeanDefinition bd = new RootBeanDefinition(RepositoryConstructorInjectionBean.class);
24592459
bd.setScope(BeanDefinition.SCOPE_PROTOTYPE);

‎spring-beans/src/test/java/org/springframework/beans/factory/config/PropertyPlaceholderConfigurerTests.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -84,7 +84,7 @@ void localPropertiesViaResource() {
8484
.getBeanDefinition());
8585

8686
PropertyPlaceholderConfigurer pc = new PropertyPlaceholderConfigurer();
87-
Resource resource = new ClassPathResource("PropertyPlaceholderConfigurerTests.properties", this.getClass());
87+
Resource resource = new ClassPathResource("PropertyPlaceholderConfigurerTests.properties", getClass());
8888
pc.setLocation(resource);
8989
pc.postProcessBeanFactory(bf);
9090
}

‎spring-beans/src/test/java/org/springframework/beans/factory/xml/DuplicateBeanIdTests.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -46,15 +46,15 @@ void duplicateBeanIdsWithinSameNestingLevelRaisesError() {
4646
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
4747
XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(bf);
4848
assertThatException().as("duplicate ids in same nesting level").isThrownBy(() ->
49-
reader.loadBeanDefinitions(new ClassPathResource("DuplicateBeanIdTests-sameLevel-context.xml", this.getClass())));
49+
reader.loadBeanDefinitions(new ClassPathResource("DuplicateBeanIdTests-sameLevel-context.xml", getClass())));
5050
}
5151

5252
@Test
5353
void duplicateBeanIdsAcrossNestingLevels() {
5454
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
5555
bf.setAllowBeanDefinitionOverriding(true);
5656
XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(bf);
57-
reader.loadBeanDefinitions(new ClassPathResource("DuplicateBeanIdTests-multiLevel-context.xml", this.getClass()));
57+
reader.loadBeanDefinitions(new ClassPathResource("DuplicateBeanIdTests-multiLevel-context.xml", getClass()));
5858
TestBean testBean = bf.getBean(TestBean.class); // there should be only one
5959
assertThat(testBean.getName()).isEqualTo("nested");
6060
}

‎spring-beans/src/test/java/org/springframework/beans/factory/xml/NestedBeansElementAttributeRecursionTests.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -36,7 +36,7 @@ class NestedBeansElementAttributeRecursionTests {
3636
void defaultLazyInit() {
3737
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
3838
new XmlBeanDefinitionReader(bf).loadBeanDefinitions(
39-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-lazy-context.xml", this.getClass()));
39+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-lazy-context.xml", getClass()));
4040

4141
assertLazyInits(bf);
4242
}
@@ -47,7 +47,7 @@ void defaultLazyInitWithNonValidatingParser() {
4747
XmlBeanDefinitionReader xmlBeanDefinitionReader = new XmlBeanDefinitionReader(bf);
4848
xmlBeanDefinitionReader.setValidating(false);
4949
xmlBeanDefinitionReader.loadBeanDefinitions(
50-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-lazy-context.xml", this.getClass()));
50+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-lazy-context.xml", getClass()));
5151

5252
assertLazyInits(bf);
5353
}
@@ -70,7 +70,7 @@ private void assertLazyInits(DefaultListableBeanFactory bf) {
7070
void defaultMerge() {
7171
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
7272
new XmlBeanDefinitionReader(bf).loadBeanDefinitions(
73-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-merge-context.xml", this.getClass()));
73+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-merge-context.xml", getClass()));
7474

7575
assertMerge(bf);
7676
}
@@ -81,7 +81,7 @@ void defaultMergeWithNonValidatingParser() {
8181
XmlBeanDefinitionReader xmlBeanDefinitionReader = new XmlBeanDefinitionReader(bf);
8282
xmlBeanDefinitionReader.setValidating(false);
8383
xmlBeanDefinitionReader.loadBeanDefinitions(
84-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-merge-context.xml", this.getClass()));
84+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-merge-context.xml", getClass()));
8585

8686
assertMerge(bf);
8787
}
@@ -109,7 +109,7 @@ private void assertMerge(DefaultListableBeanFactory bf) {
109109
void defaultAutowireCandidates() {
110110
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
111111
new XmlBeanDefinitionReader(bf).loadBeanDefinitions(
112-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-autowire-candidates-context.xml", this.getClass()));
112+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-autowire-candidates-context.xml", getClass()));
113113

114114
assertAutowireCandidates(bf);
115115
}
@@ -120,7 +120,7 @@ void defaultAutowireCandidatesWithNonValidatingParser() {
120120
XmlBeanDefinitionReader xmlBeanDefinitionReader = new XmlBeanDefinitionReader(bf);
121121
xmlBeanDefinitionReader.setValidating(false);
122122
xmlBeanDefinitionReader.loadBeanDefinitions(
123-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-autowire-candidates-context.xml", this.getClass()));
123+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-autowire-candidates-context.xml", getClass()));
124124

125125
assertAutowireCandidates(bf);
126126
}
@@ -149,7 +149,7 @@ private void assertAutowireCandidates(DefaultListableBeanFactory bf) {
149149
void initMethod() {
150150
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
151151
new XmlBeanDefinitionReader(bf).loadBeanDefinitions(
152-
new ClassPathResource("NestedBeansElementAttributeRecursionTests-init-destroy-context.xml", this.getClass()));
152+
new ClassPathResource("NestedBeansElementAttributeRecursionTests-init-destroy-context.xml", getClass()));
153153

154154
InitDestroyBean beanA = bf.getBean("beanA", InitDestroyBean.class);
155155
InitDestroyBean beanB = bf.getBean("beanB", InitDestroyBean.class);

‎spring-beans/src/test/java/org/springframework/beans/factory/xml/NestedBeansElementTests.java‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -26,15 +26,14 @@
2626

2727
import static org.assertj.core.api.Assertions.assertThat;
2828

29-
3029
/**
3130
* Tests for new nested beans element support in Spring XML
3231
*
3332
* @author Chris Beams
3433
*/
3534
class NestedBeansElementTests {
36-
private final Resource XML =
37-
new ClassPathResource("NestedBeansElementTests-context.xml", this.getClass());
35+
36+
private final Resource XML = new ClassPathResource("NestedBeansElementTests-context.xml", getClass());
3837

3938
@Test
4039
void getBean_withoutActiveProfile() {

‎spring-context/src/test/java/org/springframework/cache/interceptor/SimpleKeyGeneratorTests.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2024 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -130,7 +130,7 @@ void serializedKeys() throws Exception {
130130

131131

132132
private Object generateKey(Object[] arguments) {
133-
Method method = ReflectionUtils.findMethod(this.getClass(), "generateKey", Object[].class);
133+
Method method = ReflectionUtils.findMethod(getClass(), "generateKey", Object[].class);
134134
return this.generator.generate(this, method, arguments);
135135
}
136136

‎spring-context/src/test/java/org/springframework/context/support/PropertySourcesPlaceholderConfigurerTests.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ void localPropertiesViaResource() {
170170
.getBeanDefinition());
171171

172172
PropertySourcesPlaceholderConfigurer ppc = new PropertySourcesPlaceholderConfigurer();
173-
Resource resource = new ClassPathResource("PropertySourcesPlaceholderConfigurerTests.properties", this.getClass());
173+
Resource resource = new ClassPathResource("PropertySourcesPlaceholderConfigurerTests.properties", getClass());
174174
ppc.setLocation(resource);
175175
ppc.postProcessBeanFactory(bf);
176176
assertThat(bf.getBean(TestBean.class).getName()).isEqualTo("foo");

‎spring-core/src/main/java/org/springframework/aot/hint/AbstractTypeReference.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2023 the original author or authors.
2+
* Copyright 2002-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -81,7 +81,7 @@ protected String addPackageIfNecessary(String part) {
8181

8282
@Override
8383
public int compareTo(TypeReference other) {
84-
return this.getCanonicalName().compareToIgnoreCase(other.getCanonicalName());
84+
return getCanonicalName().compareToIgnoreCase(other.getCanonicalName());
8585
}
8686

8787
@Override

0 commit comments

Comments
 (0)