Skip to content

Add support for flush modes using FLUSHDB and FLUSHALL commands #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for flush modes using FLUSHDB and FLUSHALL commands #2190

wants to merge 2 commits into from

Conversation

@schnapster
Copy link
Contributor

@schnapster schnapster commented Nov 3, 2021

See #2187

Also relevant: redis/lettuce#1908

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 3, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 8, 2021
@mp911de mp911de linked an issue Nov 9, 2021 that may be closed by this pull request
Support ASYNC/SYNC flush modes for flushDb() and flushAll() #2187
Closed
@mp911de
Copy link
Member

mp911de commented Nov 9, 2021

Thanks for submitting a pull request. We're currently wrapping up our release and we would consider this change for the next development iteration so it will take a bit until we get to this PR.

@schnapster
Copy link
Contributor Author

schnapster commented Jan 29, 2022

Which one of next iterations did you have in mind for this @mp911de?

@mp911de mp911de self-assigned this Mar 9, 2022
@mp911de mp911de added this to the 2.7 M4 (2021.2.0) milestone Mar 9, 2022
@mp911de mp911de changed the title Implement SYNC/ASYNC Flush Modes Add support for flush modes using FLUSHDB and FLUSHALL commands Mar 10, 2022
mp911de pushed a commit that referenced this pull request Mar 10, 2022
@schnapster @mp911de
Add support for flush modes using FLUSHDB and FLUSHALL commands.
3191def 
Closes #2187
Original pull request: #2190.
mp911de added a commit that referenced this pull request Mar 10, 2022
@mp911de
Polishing.
f19a614 
Update since tags. Move FlushOption converters to client-specific converters. Use method-references where possible.

See #2187
Original pull request: #2190.
mp911de pushed a commit that referenced this pull request Mar 10, 2022
@schnapster @mp911de
Add support for flush modes using FLUSHDB and FLUSHALL commands.
3879a5a 
Closes #2187
Original pull request: #2190.
mp911de added a commit that referenced this pull request Mar 10, 2022
@mp911de
Polishing.
86d0b4f 
Update since tags. Move FlushOption converters to client-specific converters. Use method-references where possible.

See #2187
Original pull request: #2190.
@mp911de
Copy link
Member

mp911de commented Mar 10, 2022

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 10, 2022
@schnapster schnapster deleted the GH-2187-flush-modes branch March 10, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.7 M4 (2021.2.0)

Development

Successfully merging this pull request may close these issues.

Support ASYNC/SYNC flush modes for flushDb() and flushAll()

3 participants

@schnapster @mp911de @spring-projects-issues