Update to latest Eclipse 2019-09 #143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkinsona
requested changes
Sep 25, 2019
Contributor
wilkinsona
left a comment
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks very much for the PR, @BoykoAlex. I've left a couple of comments for your consideration when you have a moment.
spring-javaformat-eclipse/io.spring.javaformat.eclipse/META-INF/MANIFEST.MF
Show resolved
Hide resolved
Contributor
Author
|
@wilkinsona I have update the PR
|
wilkinsona
requested changes
Sep 25, 2019
Contributor
Author
|
@wilkinsona should be good to go now |
philwebb
pushed a commit
that referenced
this pull request
Dec 3, 2019
philwebb
added a commit
that referenced
this pull request
Dec 3, 2019
Contributor
|
Thanks very much @BoykoAlex, I've pushed this along with an additional change that allows the formatter to also run with earlier versions of Eclipse. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139