Ignore fully-qualified annotation in attribute value concision check

Closes gh-455

Author: wilkinsona

spring-javaformat/spring-javaformat-checkstyle/src/main/java/io/spring/javaformat/checkstyle/check/SpringAnnotationAttributeConciseValueCheck.java

@@ -95,20 +95,26 @@ private void visitMemberValuePair(DetailAST annotationValue) {
 	}
 
 	private void visitValueExpression(DetailAST valueExpression, DetailAST annotation, String attributeName) {
-		if (valueExpression != null && valueExpression.getChildCount() == 1) {
-			List<String> expressionComponents = dotSeparatedComponents(valueExpression.getFirstChild());
-			if (expressionComponents != null && expressionComponents.size() > 2) {
-				String outerTypeName = expressionComponents.get(0);
-				String annotationName = annotation.findFirstToken(TokenTypes.IDENT).getText();
-				if (outerTypeName.equals(annotationName)) {
-					String innerTypeName = expressionComponents.get(1);
-					if (!existingClashingImport(outerTypeName, innerTypeName)) {
-						String toImport = outerTypeName + "." + innerTypeName;
-						String replacement = String.join(".", expressionComponents.subList(1, expressionComponents.size()));
-						log(valueExpression.getLineNo(), valueExpression.getColumnNo(),
-								"annotation.attribute.overlyVerboseValue", attributeName, toImport, replacement);
-					}
-				}
+		if (valueExpression == null || valueExpression.getChildCount() != 1) {
+			return;
+		}
+		List<String> expressionComponents = dotSeparatedComponents(valueExpression.getFirstChild());
+		if (expressionComponents == null || expressionComponents.size() <= 2) {
+			return;
+		}
+		String outerTypeName = expressionComponents.get(0);
+		DetailAST annotationIdent = annotation.findFirstToken(TokenTypes.IDENT);
+		if (annotationIdent == null) {
+			return;
+		}
+		String annotationName = annotationIdent.getText();
+		if (outerTypeName.equals(annotationName)) {
+			String innerTypeName = expressionComponents.get(1);
+			if (!existingClashingImport(outerTypeName, innerTypeName)) {
+				String toImport = outerTypeName + "." + innerTypeName;
+				String replacement = String.join(".", expressionComponents.subList(1, expressionComponents.size()));
+				log(valueExpression.getLineNo(), valueExpression.getColumnNo(),
+						"annotation.attribute.overlyVerboseValue", attributeName, toImport, replacement);
 			}
 		}
 	}

spring-javaformat/spring-javaformat-checkstyle/src/test/resources/check/AnnotationWithFullyQualifiedNameAndNamedAttributeWithValueThatHasConciseReferenceToContainedEnumValue.txt

@@ -0,0 +1 @@
++0 errors

spring-javaformat/spring-javaformat-checkstyle/src/test/resources/source/AnnotationWithFullyQualifiedNameAndNamedAttributeWithValueThatHasConciseReferenceToContainedEnumValue.java

@@ -0,0 +1,20 @@
+/*
+ * Copyright 2017-present the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@com.example.web.condition.ConditionalOnWebApplicationType(type = WebApplicationType.A.B.C.D.SERVLET)
+public class AnnotationWithFullyQualifiedNameAndNamedAttributeWithValueThatHasConciseReferenceToContainedEnumValue {
+
+}