Implement feedback

Author: alexgromero

packages/smithy-http/.changes/next-release/smithy-http-feature-20251024135122.json

@@ -1,4 +1,4 @@
 {
   "type": "feature",
-  "description": "Added support for minimal components required for SDK functional testing"
+  "description": "Added `MockHTTPClient` for testing SDK clients without making real HTTP requests."
 }

packages/smithy-http/src/smithy_http/testing/__init__.py

@@ -6,8 +6,6 @@
 from .mockhttp import MockHTTPClient, MockHTTPClientError
 from .utils import create_test_request
 
-__version__ = "0.0.0"
-
 __all__ = (
     "MockHTTPClient",
     "MockHTTPClientError",

packages/smithy-http/src/smithy_http/testing/mockhttp.py

@@ -3,6 +3,7 @@
 
 from collections import deque
 from copy import copy
+from typing import Any
 
 from smithy_core.aio.utils import async_list
 
@@ -29,7 +30,7 @@ def __init__(
         client.
         """
         self._client_config = client_config
-        self._response_queue: deque[HTTPResponse] = deque()
+        self._response_queue: deque[dict[str, Any]] = deque()
         self._captured_requests: list[HTTPRequest] = []
 
     def add_response(
@@ -40,17 +41,17 @@ def add_response(
     ) -> None:
         """Queue a response for the next request.
 
-        :param status: HTTP status code (200, 404, 500, etc.)
+        :param status: HTTP status code
         :param headers: HTTP response headers as list of (name, value) tuples
         :param body: Response body as bytes
         """
-        response = HTTPResponse(
-            status=status,
-            fields=tuples_to_fields(headers or []),
-            body=async_list([body]),
-            reason=None,
+        self._response_queue.append(
+            {
+                "status": status,
+                "headers": headers or [],
+                "body": body,
+            }
         )
-        self._response_queue.append(response)
 
     async def send(
         self,
@@ -69,7 +70,13 @@ async def send(
 
         # Return next queued response or raise error
         if self._response_queue:
-            return self._response_queue.popleft()
+            response_data = self._response_queue.popleft()
+            return HTTPResponse(
+                status=response_data["status"],
+                fields=tuples_to_fields(response_data["headers"]),
+                body=async_list([response_data["body"]]),
+                reason=None,
+            )
         else:
             raise MockHTTPClientError(
                 "No responses queued in MockHTTPClient. Use add_response() to queue responses."
@@ -85,6 +92,9 @@ def captured_requests(self) -> list[HTTPRequest]:
         """The list of all requests captured by this client."""
         return self._captured_requests.copy()
 
+    def __deepcopy__(self, memo: Any) -> "MockHTTPClient":
+        return self
+
 
 class MockHTTPClientError(Exception):
     """Exception raised by MockHTTPClient for test setup issues."""

packages/smithy-http/tests/unit/testing/test_mockhttp.py

@@ -33,7 +33,7 @@ async def test_queued_responses_fifo():
     assert mock_client.call_count == 2
 
 
-async def test_captures_requests():
+async def test_captured_requests():
     # Test all requests are captured for inspection
     mock_client = MockHTTPClient()
     mock_client.add_response()
@@ -76,6 +76,7 @@ async def test_response_headers():
     assert response.status == 201
     assert "Content-Type" in response.fields
     assert response.fields["Content-Type"].as_string() == "application/json"
+    assert "X-Amz-Custom" in response.fields
     assert response.fields["X-Amz-Custom"].as_string() == "test"