Merge pull request #992 from smallstep/herman/find-more-plugins-on-windows

Find more plugins on Windows

Author: hslatman

internal/plugin/plugin.go

@@ -5,6 +5,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"runtime"
+	"strings"
 
 	"github.com/urfave/cli"
 	"go.step.sm/cli-utils/step"
@@ -19,7 +20,22 @@ func LookPath(name string) (string, error) {
 	fileName := "step-" + name + "-plugin"
 	switch runtime.GOOS {
 	case "windows":
-		for _, ext := range []string{".com", ".exe", ".bat", ".cmd"} {
+		var exts []string
+		x := os.Getenv(`PATHEXT`)
+		if x != "" {
+			for _, e := range strings.Split(strings.ToLower(x), `;`) {
+				if e == "" {
+					continue
+				}
+				if e[0] != '.' {
+					e = "." + e
+				}
+				exts = append(exts, e)
+			}
+		} else {
+			exts = []string{".com", ".exe", ".bat", ".cmd", ".ps1"}
+		}
+		for _, ext := range exts {
 			path := filepath.Join(step.BasePath(), "plugins", fileName+ext)
 			if _, err := os.Stat(path); err == nil {
 				return path, nil
@@ -38,8 +54,16 @@ func LookPath(name string) (string, error) {
 // it to complete.
 func Run(ctx *cli.Context, file string) error {
 	args := ctx.Args()
-	//nolint:gosec // arguments controlled by step.
-	cmd := exec.Command(file, args[1:]...)
+	cmdName := file
+
+	// if running on Windows and (likely) a PowerShell script, invoke powershell
+	// with the arguments instead of the plugin file directly.
+	if runtime.GOOS == "windows" && strings.ToLower(filepath.Ext(file)) == ".ps1" {
+		cmdName = "powershell"
+		args = append([]string{args[0], "-noprofile", "-nologo", file}, args[1:]...)
+	}
+
+	cmd := exec.Command(cmdName, args[1:]...)
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr