Skip to content

Commit 34f31c3

Browse files
committed
Fix jar e2e test by retrieving sig/key from JAR
Signed-off-by: Riccardo Schirone <[email protected]>
1 parent 1659155 commit 34f31c3

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

go.sum

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -529,10 +529,7 @@ golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBc
529529
golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
530530
golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
531531
golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
532-
<<<<<<< HEAD
533532
golang.org/x/sys v0.1.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
534-
=======
535-
>>>>>>> 4bb3336 (Update sigstore/sigstore with PublicKeyDetails)
536533
golang.org/x/sys v0.17.0 h1:25cE3gD+tdBA7lp7QfhuV+rJiE9YXTcS3VG1SqssI/Y=
537534
golang.org/x/sys v0.17.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
538535
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=

pkg/types/jar/v0.0.1/entry.go

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -324,12 +324,30 @@ func (v *V001Entry) CreateFromArtifactProperties(ctx context.Context, props type
324324
}
325325
re.JARModel.Archive.Content = (strfmt.Base64)(artifactBytes)
326326

327-
if err := re.validate(); err != nil {
327+
keyObj, sigObj, err := re.fetchExternalEntities(ctx)
328+
if err != nil {
329+
return nil, fmt.Errorf("error retrieving external entities: %v", err)
330+
}
331+
332+
// need to canonicalize key content
333+
keyContent, err := keyObj.CanonicalValue()
334+
if err != nil {
335+
return nil, err
336+
}
337+
sigContent, err := sigObj.CanonicalValue()
338+
if err != nil {
328339
return nil, err
329340
}
330341

331-
if _, _, err := re.fetchExternalEntities(ctx); err != nil {
332-
return nil, fmt.Errorf("error retrieving external entities: %v", err)
342+
re.JARModel.Signature = &models.JarV001SchemaSignature{
343+
PublicKey: &models.JarV001SchemaSignaturePublicKey{
344+
Content: (*strfmt.Base64)(&keyContent),
345+
},
346+
Content: sigContent,
347+
}
348+
349+
if err := re.validate(); err != nil {
350+
return nil, err
333351
}
334352

335353
returnVal.APIVersion = swag.String(re.APIVersion())

0 commit comments

Comments
 (0)