fix some bugs in processing#561

shinytang6 · shinytang6 · commit 688fc347f8cc · 2018-02-27T21:51:56.000+08:00
diff --git a/client/modules/IDE/pages/IDEView.jsx b/client/modules/IDE/pages/IDEView.jsx
@@ -124,6 +124,7 @@ class IDEView extends React.Component {
   }
 
   componentWillUnmount() {
+    document.removeEventListener('keydown', this.handleGlobalKeydown, false);
     clearTimeout(this.autosaveInterval);
     this.autosaveInterval = null;
     this.consoleSize = undefined;
@@ -490,6 +491,7 @@ class IDEView extends React.Component {
           <Overlay
             title="Error"
             ariaLabel="error"
+            closeOverlay={this.props.hideErrorModal}
           >
             <ErrorModal
               type={this.props.ide.errorType}

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,7 @@ class IDEView extends React.Component {`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`componentWillUnmount() {`
	`127`	`+ document.removeEventListener('keydown', this.handleGlobalKeydown, false);`
`127`	`128`	`clearTimeout(this.autosaveInterval);`
`128`	`129`	`this.autosaveInterval = null;`
`129`	`130`	`this.consoleSize = undefined;`
`@@ -490,6 +491,7 @@ class IDEView extends React.Component {`
`490`	`491`	`<Overlay`
`491`	`492`	`title="Error"`
`492`	`493`	`ariaLabel="error"`
	`494`	`+ closeOverlay={this.props.hideErrorModal}`
`493`	`495`	`>`
`494`	`496`	`<ErrorModal`
`495`	`497`	`type={this.props.ide.errorType}`