Fix: Skip validation in precompile hook to prevent generator failures

The shakapacker-precompile-hook was causing generator failures because
it loads the Rails environment (which triggers version validation)
before the react-on-rails npm package is installed during initial setup.

This fix adds ENV["REACT_ON_RAILS_SKIP_VALIDATION"] = "true" at the start
of the hook script to skip version validation, since the hook runs as part
of the build process and doesn't need package version validation.

Fixes CI failures in generator tests where the hook was executed during
`rails generate react_on_rails:install` before packages were installed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/base_generator.rb

@@ -45,8 +45,8 @@ def copy_base_files
           template("#{base_path}/#{file}.tt", file)
         end
 
-        # Make the hook script executable
-        File.chmod(0o755, "bin/shakapacker-precompile-hook") if File.exist?("bin/shakapacker-precompile-hook")
+        # Make the hook script executable (copy_file guarantees it exists)
+        File.chmod(0o755, File.join(destination_root, "bin/shakapacker-precompile-hook"))
       end
 
       def copy_js_bundle_files

lib/generators/react_on_rails/templates/base/base/bin/shakapacker-precompile-hook

@@ -7,6 +7,16 @@
 # for auto-bundled components. It's called automatically by Shakapacker
 # when configured in config/shakapacker.yml:
 #   precompile_hook: 'bin/shakapacker-precompile-hook'
+#
+# Emoji Scheme:
+#   🔄 = Running/in-progress
+#   ✅ = Success
+#   ❌ = Error
+
+# Skip validation during precompile hook execution
+# The hook runs early in the build process, potentially before full Rails initialization,
+# and doesn't need package version validation since it's part of the build itself
+ENV["REACT_ON_RAILS_SKIP_VALIDATION"] = "true"
 
 require_relative "../config/environment"
 

spec/react_on_rails/dev/pack_generator_spec.rb

@@ -5,6 +5,33 @@
 
 RSpec.describe ReactOnRails::Dev::PackGenerator do
   describe ".generate" do
+    context "when shakapacker precompile hook is configured" do
+      before do
+        allow(ReactOnRails::PackerUtils).to receive(:shakapacker_precompile_hook_configured?).and_return(true)
+      end
+
+      it "skips pack generation in verbose mode" do
+        expect { described_class.generate(verbose: true) }
+          .to output(/⏭️  Skipping pack generation/).to_stdout_from_any_process
+      end
+
+      it "skips pack generation silently in quiet mode" do
+        expect { described_class.generate(verbose: false) }
+          .not_to output.to_stdout_from_any_process
+      end
+
+      it "does not invoke the rake task" do
+        # Mock the task to ensure it's not called
+        mock_task = instance_double(Rake::Task)
+        allow(Rake::Task).to receive(:[]).with("react_on_rails:generate_packs").and_return(mock_task)
+        allow(mock_task).to receive(:invoke)
+
+        described_class.generate(verbose: false)
+
+        expect(mock_task).not_to have_received(:invoke)
+      end
+    end
+
     context "when in Bundler context with Rails available" do
       let(:mock_task) { instance_double(Rake::Task) }
       let(:mock_rails_app) do
@@ -17,6 +44,9 @@
       end
 
       before do
+        # Ensure precompile hook is not configured for these tests
+        allow(ReactOnRails::PackerUtils).to receive(:shakapacker_precompile_hook_configured?).and_return(false)
+
         # Setup Bundler context
         stub_const("Bundler", Module.new)
         allow(ENV).to receive(:[]).and_call_original

spec/react_on_rails/packer_utils_spec.rb

@@ -139,6 +139,48 @@ module ReactOnRails
         expect(described_class.supports_autobundling?).to be(false)
       end
     end
+
+    describe ".shakapacker_precompile_hook_configured?" do
+      let(:mock_config) { instance_double("::Shakapacker::Config") } # rubocop:disable RSpec/VerifiedDoubleReference
+
+      before do
+        allow(::Shakapacker).to receive(:config).and_return(mock_config)
+      end
+
+      context "when precompile_hook is configured" do
+        it "returns true" do
+          allow(mock_config).to receive(:send).with(:data).and_return({ precompile_hook: "bin/hook" })
+          expect(described_class.shakapacker_precompile_hook_configured?).to be true
+        end
+      end
+
+      context "when precompile_hook is not configured" do
+        it "returns false for nil" do
+          allow(mock_config).to receive(:send).with(:data).and_return({ precompile_hook: nil })
+          expect(described_class.shakapacker_precompile_hook_configured?).to be false
+        end
+
+        it "returns false for empty string" do
+          allow(mock_config).to receive(:send).with(:data).and_return({ precompile_hook: "" })
+          expect(described_class.shakapacker_precompile_hook_configured?).to be false
+        end
+      end
+
+      context "when Shakapacker is not available" do
+        before { hide_const("::Shakapacker") }
+
+        it "returns false" do
+          expect(described_class.shakapacker_precompile_hook_configured?).to be false
+        end
+      end
+
+      context "when config.send raises an error" do
+        it "returns false" do
+          allow(mock_config).to receive(:send).and_raise(NoMethodError)
+          expect(described_class.shakapacker_precompile_hook_configured?).to be false
+        end
+      end
+    end
   end
 
   describe "version constants validation" do