Add some basic logging. #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log results of cache operations for SimpleCache and FileSystemCache as a start at improving observability (pallets-eco#182, pallets-eco#17). Also include some minor code improvements.
jab
commented
Nov 27, 2020
| hit_or_miss = "hit" | ||
| try: | ||
| result = pickle.loads(value) | ||
| except Exception as exc: |
There was a problem hiding this comment.
Quoting https://docs.python.org/3/library/pickle.html#pickle.UnpicklingError
Note that other exceptions may also be raised during unpickling, including (but not necessarily limited to) AttributeError, EOFError, ImportError, and IndexError.
so I broadened the except to catch Exception, but narrowed it around just the pickle.loads() call.
| @@ -31,6 +38,7 @@ def test_cache_delete_many(app, cache): | |||
| assert cache.get("hi") is not None | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(HAS_NOT_REDIS, reason="requires Redis") | |||
| def test_cache_unlink(app, redis_server): | |||
There was a problem hiding this comment.
Looked like this test was missing the skipif(HAS_NOT_REDIS) that the other Redis-requiring tests have, so I fixed that while I was in here.
Closed
|
Thanks a lot! |
|
My pleasure, and thank you for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log results of cache operations for SimpleCache and FileSystemCache as a first step toward improving observability (#182, #17). The remaining cache backends can be updated similarly in followup work as desired.
Also include some minor code improvements (see my review comments).
Run
pytestwith--log-cli-level=debugfor a quick way to view example log output from these changes.UPDATE: All tests passed on Travis. ✔️