Skip to content

Commit f6d85b0

Browse files
committed
fix: Seperate createTraceSpan tests into its own block
1 parent c43f756 commit f6d85b0

File tree

1 file changed

+28
-9
lines changed

1 file changed

+28
-9
lines changed

node/packages/sdk/test/unit/index.test.js

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,34 @@ describe('index.test.js', () => {
4848
expect(serverlessSdk._customTags.get('tag')).to.equal('value');
4949
});
5050

51+
it('should not crash on invalid .setTag input', () => {
52+
delete process.env.SLS_CRASH_ON_SDK_ERROR;
53+
try {
54+
serverlessSdk.setTag();
55+
} finally {
56+
process.env.SLS_CRASH_ON_SDK_ERROR = '1';
57+
}
58+
});
59+
});
60+
61+
describe('.createTraceSpan', () => {
62+
let serverlessSdk;
63+
let rootSpan;
64+
before(() => {
65+
process.env.SLS_CRASH_ON_SDK_ERROR = '1';
66+
requireUncached(() => {
67+
const TraceSpan = require('../../lib/trace-span');
68+
serverlessSdk = require('../../');
69+
// Ensure to trigger unerlying lazy require
70+
serverlessSdk.instrumentation.expressApp;
71+
rootSpan = new TraceSpan('test');
72+
});
73+
});
74+
after(() => {
75+
rootSpan.close();
76+
delete require('uni-global')('serverless/sdk/202212').serverlessSdk;
77+
});
78+
before(() => {});
5179
it('should expose .createTraceSpan', () => {
5280
expect(serverlessSdk.createTraceSpan).to.be.instanceOf(Object);
5381
});
@@ -86,13 +114,4 @@ describe('index.test.js', () => {
86114
expect(spans[0].endTime).to.not.be.undefined;
87115
expect(result).to.equal('test');
88116
});
89-
90-
it('should not crash on invalid .setTag input', () => {
91-
delete process.env.SLS_CRASH_ON_SDK_ERROR;
92-
try {
93-
serverlessSdk.setTag();
94-
} finally {
95-
process.env.SLS_CRASH_ON_SDK_ERROR = '1';
96-
}
97-
});
98117
});

0 commit comments

Comments
 (0)