refactor: Seclude isApiEvent util

Author: medikoo

node/packages/aws-lambda-sdk/instrument/lib/is-api-event.js

@@ -0,0 +1,12 @@
+'use strict';
+
+const awsLambdaSpan = require('./sdk').traceSpans.awsLambda;
+
+const apiEventTypes = new Set([
+  'aws.apigateway.rest',
+  'aws.apigatewayv2.http.v1',
+  'aws.apigatewayv2.http.v2',
+  'aws.lambda.url',
+]);
+
+module.exports = () => apiEventTypes.has(awsLambdaSpan.tags.get('aws.lambda.event_type'));

node/packages/aws-lambda-sdk/instrument/lib/resolve-response-tags.js

@@ -1,33 +1,22 @@
 'use strict';
 
 const coerceNaturalNumber = require('type/natural-number/coerce');
+const isApiEvent = require('./is-api-event');
 
 const awsLambdaSpan = require('./sdk').traceSpans.awsLambda;
 
 module.exports = (response) => {
-  switch (awsLambdaSpan.tags.get('aws.lambda.event_type')) {
-    case 'aws.apigateway.rest':
-    case 'aws.apigatewayv2.http.v1':
-    case 'aws.apigatewayv2.http.v2':
-    case 'aws.lambda.url':
-      {
-        let statusCode = response && response.statusCode;
-        if (statusCode == null) {
-          awsLambdaSpan.tags.set('aws.lambda.http.error_code', 'MISSING_STATUS_CODE');
-          break;
-        }
-        if (typeof statusCode === 'string') statusCode = Number(statusCode);
-        if (
-          coerceNaturalNumber(statusCode) === statusCode &&
-          statusCode >= 100 &&
-          statusCode < 600
-        ) {
-          awsLambdaSpan.tags.set('aws.lambda.http.status_code', statusCode);
-        } else {
-          awsLambdaSpan.tags.set('aws.lambda.http.error_code', 'INVALID_STATUS_CODE');
-        }
-      }
-      break;
-    default:
+  if (isApiEvent()) {
+    let statusCode = response && response.statusCode;
+    if (statusCode == null) {
+      awsLambdaSpan.tags.set('aws.lambda.http.error_code', 'MISSING_STATUS_CODE');
+      return;
+    }
+    if (typeof statusCode === 'string') statusCode = Number(statusCode);
+    if (coerceNaturalNumber(statusCode) === statusCode && statusCode >= 100 && statusCode < 600) {
+      awsLambdaSpan.tags.set('aws.lambda.http.status_code', statusCode);
+    } else {
+      awsLambdaSpan.tags.set('aws.lambda.http.error_code', 'INVALID_STATUS_CODE');
+    }
   }
 };