Skip to content

Commit 5f44099

Browse files
committed
fix: Ensure sdk.runtime tag on all payloads
1 parent 9ecade7 commit 5f44099

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

node/packages/aws-lambda-sdk/instrument/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const reportRequest = async (event, context) => {
6565
slsTags: {
6666
orgId: serverlessSdk.orgId,
6767
service: process.env.AWS_LAMBDA_FUNCTION_NAME,
68-
sdk: { name: pkgJson.name, version: pkgJson.version },
68+
sdk: { name: pkgJson.name, version: pkgJson.version, runtime: 'nodejs' },
6969
},
7070
traceId: Buffer.from(awsLambdaSpan.traceId),
7171
spanId: Buffer.from(awsLambdaSpan.id),
@@ -133,7 +133,7 @@ const reportTrace = ({ isErrorOutcome }) => {
133133
slsTags: {
134134
orgId: serverlessSdk.orgId,
135135
service: process.env.AWS_LAMBDA_FUNCTION_NAME,
136-
sdk: { name: pkgJson.name, version: pkgJson.version },
136+
sdk: { name: pkgJson.name, version: pkgJson.version, runtime: 'nodejs' },
137137
},
138138
spans: Array.from(awsLambdaSpan.spans, (span) => {
139139
if (isSampledOut && !coreTraceSpanNames.has(span.name)) return null;

node/packages/aws-lambda-sdk/test/integration/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2076,7 +2076,7 @@ describe('integration', function () {
20762076
expect(slsTags).to.deep.equal({
20772077
orgId: process.env.SLS_ORG_ID,
20782078
service: testConfig.configuration.FunctionName,
2079-
sdk: { name: pkgJson.name, version: pkgJson.version },
2079+
sdk: { name: pkgJson.name, version: pkgJson.version, runtime: 'nodejs' },
20802080
});
20812081
expect(lambdaSpan.tags.aws.lambda).to.have.property('arch');
20822082
expect(lambdaSpan.tags.aws.lambda.name).to.equal(testConfig.configuration.FunctionName);

node/packages/aws-lambda-sdk/test/unit/internal-extension/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const handleInvocation = async (handlerModuleName, options = {}) => {
8686
expect(outcome.trace.input.slsTags).to.deep.equal({
8787
orgId: process.env.SLS_ORG_ID,
8888
service: functionName,
89-
sdk: { name: pkgJson.name, version: pkgJson.version },
89+
sdk: { name: pkgJson.name, version: pkgJson.version, runtime: 'nodejs' },
9090
});
9191
const [lambdaSpan, initializationSpan, ...otherSpans] = outcome.trace.input.spans;
9292
const lambdaSpanTags = lambdaSpan.tags;

0 commit comments

Comments
 (0)