Skip to content

3.2.0 Release #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 12, 2019
Merged

3.2.0 Release #150

merged 14 commits into from
Nov 12, 2019

Conversation

@nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Nov 11, 2019

nblumhardt and others added 14 commits October 14, 2019 19:08
@nblumhardt
Dev version bump [skip ci]
7116569
@tomkerkhove
Add RequestHost & RequestScheme to log properties
3852fa1
@tomkerkhove
Remove spaces
166783d
@tomkerkhove
Align with suggested approach
398cc94 
Signed-off-by: Tom Kerkhove <[email protected]>
@tomkerkhove
Merge branch 'request-log-properties' of https://github.com/tomkerkho…
32fde1d 
…ve/serilog-aspnetcore into request-log-properties
@nblumhardt
Some slight README organization tweaks
8651ec7
@nblumhardt
Use the simpler defaults in examples.
3f0b9a6
@nblumhardt
Use simpler defaults in examples.
90587d1
@nblumhardt
Some minor doc edits.
c350bce
@nblumhardt
Merge pull request #146 from tomkerkhove/request-log-properties
5aa8333 
Add RequestHost & RequestScheme to log properties
@nblumhardt
Request logging and provider support have shipped [skip ci]
00c6182
@nblumhardt
Now supports options.EnrichDiagnosticContext
fd6bf02
@alastair-gatpark
FIX: Enrich context before collecting properties
db1e058 
LogCompletion event was not including properties added via
`EnrichDiagnosticContext` delegate on options because
the properties had been collected before invoking the enricher.

Swapping the order of the statements fixes this.
@nblumhardt
Merge pull request #149 from purplepangolin/dev
27d696d 
FIX: Enrich context before collecting properties
@nblumhardt nblumhardt marked this pull request as ready for review November 12, 2019 02:31
@nblumhardt nblumhardt merged commit 210a242 into master Nov 12, 2019
@D9001
Copy link

D9001 commented Nov 12, 2019

I just pulled down 3.2.0 and had to downgrade back to a dev version in order to use the properties in the docs 😥
At the very least, could you hold off on updating the readme with these methods until they're available in the stable release? I found your blogs very helpful and informative but was really confused when I couldn't find these methods even though they were in the docs.

@nblumhardt
Copy link
Member Author

nblumhardt commented Nov 12, 2019

Hi! Do you mean you pulled down 3.1.0? Version 3.2.0 is out now and includes everything that's in the README.

Unfortunately GitHub conflates the default branch for PRs (which needs to be dev, or else we have to field a whole lot of misdirected effort when people accidentally code PRs against the older code in master), and the branch from which README is shown.

In future my plan's to tag pre-release features in the README - tried that recently with 3.0.0-* to some degree of success, should have done the same for EnrichDiagnosticContext - sorry about the confusion.

In any case, grabbing the latest from NuGet now should have you sorted :-)

@D9001
Copy link

D9001 commented Nov 12, 2019 •
edited
Loading

That makes sense (about the readme). Thank you!
When I pull 3.2.0, EnrichDiagnosticContext appears unavailable until I switch to 3.2.0-devxxx or even 3.1.1-devxx. It's very strange.

Edit: I restarted my IDE (Jetbrains) and all is well. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nblumhardt @D9001 @purplepangolin @tomkerkhove @alastair-gatpark