Fix single character reads on windows #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
approved these changes
Dec 23, 2024
Member
reconbot
left a comment
reconbot
left a comment
There was a problem hiding this comment.
This is a great catch, thank you. Just need's one change. I'll merge as is and add that in so I can do a release today.
| baton->offset += bytesTransferred; | ||
| } | ||
| if (!baton->bytesToRead) { | ||
| baton->complete = true; |
Member
There was a problem hiding this comment.
We need a CloseHandle(ov->hEvent); here
reconbot
added a commit
that referenced
this pull request
Dec 23, 2024
Makes sure we always close the event handle when we're done reading. Finishes up #165
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project using
@serialport/bindings-cppthat works without issues on MacOS and Linux, but on windows every read fails withThe device I'm talking to has a binary protocol, and all exchanges begin with a single character write to the device, a single character response from the device, and then further, longer exchanges. The single character read always fails.
This is because
ReadThreaddoes a single character read usingReadFileEx, and then, unconditionally reads "the rest of the data" usingReadFile. But in the case of a single character read there is no "rest of the data". This pull request fixes it by checking for no more data before issuing theReadFile.I don't know how to write a test that would fail without the fix.