Skip to content

Commit c6adf14

Browse files
authored
Merge pull request #3623 from sarr423/fix_3376
a fix of issue 3376
2 parents e0f15da + 87007a8 commit c6adf14

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

php/lang/security/injection/tainted-sql-string.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,14 @@ function test4() {
3131
return $info;
3232
}
3333

34+
function test5() {
35+
// ruleid: tainted-sql-string
36+
$query = "
37+
SELECT * FROM table WHERE Id = '".$_GET['url']."'";
38+
$info = mysql_query($query);
39+
return $info;
40+
}
41+
3442
// True Negatives
3543

3644
function test1() {

php/lang/security/injection/tainted-sql-string.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,16 @@ rules:
4646
sprintf($SQLSTR, ...)
4747
- metavariable-regex:
4848
metavariable: $SQLSTR
49-
regex: .*\b(?i)(select|delete|insert|create|update|alter|drop)\b.*
49+
regex: (?is).*\b(select|delete|insert|create|update|alter|drop)\b.*
5050
- patterns:
5151
- pattern: |
5252
"...$EXPR..."
5353
- metavariable-regex:
5454
metavariable: $EXPR
55-
regex: .*\b(?i)(select|delete|insert|create|update|alter|drop)\b.*
55+
regex: (?is).*\b(select|delete|insert|create|update|alter|drop)\b.*
5656
- patterns:
5757
- pattern: |
5858
"$SQLSTR".$EXPR
5959
- metavariable-regex:
6060
metavariable: $SQLSTR
61-
regex: .*\b(?i)(select|delete|insert|create|update|alter|drop)\b.*
61+
regex: (?is).*\b(select|delete|insert|create|update|alter|drop)\b.*

0 commit comments

Comments
 (0)