Skip to content

Commit 18dd4e4

Browse files
author
King Long Tse
authored
Fix: bad code generated in minified code (#52)
* bumped version * fixed bad snippet.min() results * fixed missing SNIPPET_VERSION in minified code
1 parent e27dabf commit 18dd4e4

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function defaults(options) {
5353
options || (options = {});
5454
options.apiKey || (options.apiKey = 'YOUR_API_KEY');
5555
options.host || (options.host = 'cdn.segment.com');
56-
options.ajsPath || (options.ajsPath = '/analytics.js/v1/\' + key + \'/analytics.min.js');
56+
options.ajsPath || (options.ajsPath = '/analytics.js/v1/\" + key + \"/analytics.min.js');
5757
if (!has.call(options, 'page')) options.page = true;
5858
if (!has.call(options, 'load')) options.load = true;
5959
return options;

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/snippet",
33
"author": "Segment.io <[email protected]>",
4-
"version": "4.13.0",
4+
"version": "4.13.1",
55
"repository": "git://github.com/segmentio/snippet.git",
66
"description": "Templating methods for rendering the analytics.js snippet.",
77
"main": "lib/index.js",

scripts/build.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ var lineRegex = /(<%= settings\.load %>|<%= settings\.page %>|}}\(\);)/g;
1515
var versionRegex = /<%= settings\.version %>/;
1616
var snippet = template(source.replace(loadRegex, '$1').replace(pageRegex, '$1').replace(versionRegex, packageJSON.version), { variable: 'settings' });
1717
var snippetMin = template(minify(source, {
18-
mangle: { except: ['analytics'] },
18+
mangle: { except: ['analytics', 'key'] },
1919
compress: { sequences: false, side_effects: false },
2020
fromString: true
21-
}).code.replace(loadRegex, '$1').replace(pageRegex, '$1').replace(lineRegex, '\n$1'), { variable: 'settings' });
21+
}).code.replace(loadRegex, '$1').replace(pageRegex, '$1').replace(lineRegex, '\n$1').replace(versionRegex, packageJSON.version), { variable: 'settings' });
2222

2323
mkdirp(path.join(__dirname, '../dist'), function() {
2424
fs.writeFileSync(path.join(__dirname, '../dist/max.template.js'), 'module.exports=' + snippet.source);

template/snippet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
var script = document.createElement('script');
6969
script.type = 'text/javascript';
7070
script.async = true;
71-
script.src = 'https://<%= settings.host %><%= settings.ajsPath %>';
71+
script.src = "https://<%= settings.host %><%= settings.ajsPath %>";
7272

7373
// Insert our script next to the first script element.
7474
var first = document.getElementsByTagName('script')[0];

0 commit comments

Comments
 (0)