[walkme] bump integration version to 1.2.0 #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varadarajan-tw
force-pushed
the
bump-walkme-version
branch
from
834fe97 to
a3e72ec
Compare
sayan-das-in
approved these changes
Jul 18, 2023
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit * added console to track --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 7, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 7, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap * added logs in track and page events --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps the version of walkme to 1.2.0. The new version now implements the option to load walkme script from a custom directory in s3
Are there breaking changes in this PR?
No. The changes are backward compatible.
Testing
Testing not required because this PR just updates the version
Any background context you want to provide?
Refer PR #759 for more details on the code changes
Is there parity with the server-side/android/iOS integration components (if applicable)?
N/A
Does this require a new integration setting? If so, please explain how the new setting works
N/A
Links to helpful docs and other external resources