Update Kissmetrics domain #482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io#742) * STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (segmentio#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads * Added product Id in Ordered Product track event of klaviyo (segmentio#736) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added --------- Co-authored-by: Ankit Gupta <[email protected]> * HGI-394 klaviyo package.json Version update (segmentio#738) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added * Klaviyo version update --------- Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * HGI-404 version upgraded of sentry from 5.12.1 to 7.45.0 * HGI-404 change cdn settings --------- Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
* STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (segmentio#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads * Added product Id in Ordered Product track event of klaviyo (segmentio#736) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added --------- Co-authored-by: Ankit Gupta <[email protected]> * HGI-394 klaviyo package.json Version update (segmentio#738) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added * Klaviyo version update --------- Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * HGI-404 version upgraded of sentry from 5.12.1 to 7.45.0 * HGI-404 change cdn settings * Package version change for sentry --------- Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
…ify whether to load iframe to head or body
…integrations into strat-1996
but using `users` instead a custom name as we dont need to create a temporary directory on S3, the actual literal use is not important
* [Walkme] Add option to choose a custom bucket (segmentio#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (segmentio#768) * fixes typo and related test (segmentio#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (segmentio#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
This reverts commit 2a89693.
* [Walkme] Add option to choose a custom bucket (segmentio#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (segmentio#768) * fixes typo and related test (segmentio#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (segmentio#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit * added console to track --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
This reverts commit 95086a2.
* [Walkme] Add option to choose a custom bucket (segmentio#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (segmentio#768) * fixes typo and related test (segmentio#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (segmentio#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
* [Walkme] Add option to choose a custom bucket (segmentio#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (segmentio#768) * fixes typo and related test (segmentio#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (segmentio#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
* [Walkme] Add option to choose a custom bucket (segmentio#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (segmentio#768) * fixes typo and related test (segmentio#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (segmentio#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
* [Walkme] Add option to choose a custom bucket (segmentio#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (segmentio#768) * fixes typo and related test (segmentio#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (segmentio#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap * added logs in track and page events --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
mattkissmetrics
approved these changes
Oct 10, 2023
mattkissmetrics
left a comment
mattkissmetrics
left a comment
There was a problem hiding this comment.
Approving this as it is regarding the deprecation of the Kissmetrics.com domain and changing the end points to kissmetrics.io.
Contributor
|
This PR has some conflicts and having other changes as well .I have created a separate PR #789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the kissmetrics domain and increments the kissmetrics integration version
Are there breaking changes in this PR?
While the interfaces are the same, at some point in the near future we will be deprecating the current domain in favor of the domain included here. Users will need to migrate to this new domain if they want their tracking to continue uninterrupted. Currently, we support tracking at both domains.
Any background context you want to provide?
N/A
Is there parity with the server-side/android/iOS integration components (if applicable)?
Please advise, I'll submit PRs as necessary.
Does this require a new integration setting? If so, please explain how the new setting works
No new settings.
Links to helpful docs and other external resources
Our support docs are located here: https://support.kissmetrics.io/
The current domain https://www.kissmetricshq.com will be switched to https://www.kissmetrics.io shortly.