Merge pull request #149 from GoASTScanner/experimental

gcmurphy · web-flow · commit 9a2bec1cd013 · 2018-01-05T22:20:21.000+10:00
Fix nil pointer dereference in complit types
diff --git a/rules/tls.go b/rules/tls.go
@@ -106,7 +106,7 @@ func (t *insecureConfigTLS) processTLSConfVal(n *ast.KeyValueExpr, c *gas.Contex
 }
 
 func (t *insecureConfigTLS) Match(n ast.Node, c *gas.Context) (*gas.Issue, error) {
-	if complit, ok := n.(*ast.CompositeLit); ok && c.Info.TypeOf(complit.Type).String() == t.requiredType {
+	if complit, ok := n.(*ast.CompositeLit); ok && complit.Type != nil && c.Info.TypeOf(complit.Type).String() == t.requiredType {
 		for _, elt := range complit.Elts {
 			if kve, ok := elt.(*ast.KeyValueExpr); ok {
 				issue := t.processTLSConfVal(kve, c)

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ func (t insecureConfigTLS) processTLSConfVal(n ast.KeyValueExpr, c *gas.Contex`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`func (t insecureConfigTLS) Match(n ast.Node, c gas.Context) (*gas.Issue, error) {`
`109`		`- if complit, ok := n.(*ast.CompositeLit); ok && c.Info.TypeOf(complit.Type).String() == t.requiredType {`
	`109`	`+ if complit, ok := n.(*ast.CompositeLit); ok && complit.Type != nil && c.Info.TypeOf(complit.Type).String() == t.requiredType {`
`110`	`110`	`for _, elt := range complit.Elts {`
`111`	`111`	`if kve, ok := elt.(*ast.KeyValueExpr); ok {`
`112`	`112`	`issue := t.processTLSConfVal(kve, c)`