Skip to content

Commit 8125622

Browse files
authored
Merge pull request #162 from gcmurphy/bugfix
Cleanup vet failures and unused files
2 parents 07a2eec + a97a196 commit 8125622

File tree

4 files changed

+4
-32
lines changed

4 files changed

+4
-32
lines changed

analyzer_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package gas_test
22

33
import (
4-
"bytes"
54
"io/ioutil"
65
"log"
76
"os"
@@ -20,10 +19,9 @@ var _ = Describe("Analyzer", func() {
2019
var (
2120
analyzer *gas.Analyzer
2221
logger *log.Logger
23-
output *bytes.Buffer
2422
)
2523
BeforeEach(func() {
26-
logger, output = testutils.NewLogger()
24+
logger, _ = testutils.NewLogger()
2725
analyzer = gas.NewAnalyzer(nil, logger)
2826
})
2927

glide.lock

Lines changed: 0 additions & 25 deletions
This file was deleted.

import_tracker_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package gas_test
22

33
import (
44
. "github.com/onsi/ginkgo"
5-
//. "github.com/onsi/gomega"
5+
. "github.com/onsi/gomega"
66
)
77

88
var _ = Describe("ImportTracker", func() {
@@ -15,6 +15,7 @@ var _ = Describe("ImportTracker", func() {
1515
})
1616
Context("when I have a valid go package", func() {
1717
It("should record all import specs", func() {
18+
Expect(source).To(Equal(source))
1819
Skip("Not implemented")
1920
})
2021

rules/rules_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package rules_test
22

33
import (
4-
"bytes"
54
"fmt"
65
"log"
76

@@ -17,14 +16,13 @@ var _ = Describe("gas rules", func() {
1716

1817
var (
1918
logger *log.Logger
20-
output *bytes.Buffer
2119
config gas.Config
2220
analyzer *gas.Analyzer
2321
runner func(string, []testutils.CodeSample)
2422
)
2523

2624
BeforeEach(func() {
27-
logger, output = testutils.NewLogger()
25+
logger, _ = testutils.NewLogger()
2826
config = gas.NewConfig()
2927
analyzer = gas.NewAnalyzer(config, logger)
3028
runner = func(rule string, samples []testutils.CodeSample) {

0 commit comments

Comments
 (0)