Encode the selectDynamic names in ScalaJS

hamzaremmal · hamzaremmal · commit c058de03e909 · 2023-11-14T20:28:44.000+01:00
diff --git a/compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala b/compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala
@@ -36,6 +36,7 @@ import dotty.tools.dotc.transform.sjs.JSSymUtils.*
 
 import JSEncoding.*
 import ScopedVar.withScopedVars
+import scala.reflect.NameTransformer
 
 /** Main codegen for Scala.js IR.
  *
@@ -4218,7 +4219,7 @@ class JSCodeGen()(using genCtx: Context) {
       }
     }
 
-    val methodName = MethodName.reflectiveProxy(methodNameStr, formalParamTypeRefs)
+    val methodName = MethodName.reflectiveProxy(NameTransformer.encode(methodNameStr), formalParamTypeRefs)
 
     js.Apply(js.ApplyFlags.empty, selectedValueTree, js.MethodIdent(methodName), actualArgs)(jstpe.AnyType)
   }

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ import dotty.tools.dotc.transform.sjs.JSSymUtils.*`
`36`	`36`
`37`	`37`	`import JSEncoding.*`
`38`	`38`	`import ScopedVar.withScopedVars`
	`39`	`+import scala.reflect.NameTransformer`
`39`	`40`
`40`	`41`	`/** Main codegen for Scala.js IR.`
`41`	`42`	`*`
`@@ -4218,7 +4219,7 @@ class JSCodeGen()(using genCtx: Context) {`
`4218`	`4219`	`}`
`4219`	`4220`	`}`
`4220`	`4221`
`4221`		`- val methodName = MethodName.reflectiveProxy(methodNameStr, formalParamTypeRefs)`
	`4222`	`+ val methodName = MethodName.reflectiveProxy(NameTransformer.encode(methodNameStr), formalParamTypeRefs)`
`4222`	`4223`
`4223`	`4224`	`js.Apply(js.ApplyFlags.empty, selectedValueTree, js.MethodIdent(methodName), actualArgs)(jstpe.AnyType)`
`4224`	`4225`	`}`