Update syntax summary to align with chapter text #7514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also include a supplementary rewording inspired by a stack overflow question not quite covered by the One Question FAQ, which finally let us down after all these years. |
lrytz
approved these changes
Dec 12, 2018
Member
|
🎃 is that a squash? is that different than pumpkin? |
Align summary with chapter 8 Align summary vertically Emphasize that strictly evaluated expressions in the definition of an overridden member are included in initialization. Also correct "overwrite" to "override", as the former term may seem to imply writing to a field.
som-snytt
force-pushed
the
issue/boundvarid-summary
branch
from
1a1678c to
c19525a
Compare
Contributor
Author
|
I pancaked them, even though there were two different changes. |
lrytz
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4935
I guess there was going to be a tool for this, ScalaSpecFix.