-
Notifications
You must be signed in to change notification settings - Fork 15
feat: save identity data to sf's config and to the server #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aah. Thought |
Co-authored-by: Kevin Hawkins <[email protected]>
src/shared/previewUtils.ts
Outdated
| public static generateDesktopPreviewLaunchArguments( | ||
| public static async generateDesktopPreviewLaunchArguments( | ||
| ldpServerUrl: string, | ||
| username: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sort of a "one of these things is not like the other", in that the rest of the input parameters are more or less directly plugged into the functions of this method, whereas username is indirectly used as a lookup.
Should we retrieve the Entity ID beforehand, and pass that value in as the input parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it would be more consistent to look up Entity ID (in some capacity) in app.ts, somewhere around where the ldpServerUrl is determined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my only outstanding comment was the username lookup, but otherwise this all looks fine to me.
What does this PR do?
sf's configWhat issues does this PR fix or reference?
@W-15428971@