Skip to content

Conversation

@sfdctaka
Copy link
Contributor

@sfdctaka sfdctaka commented Jul 9, 2024

What does this PR do?

  • Saves identity data structure in sf's config
  • Saves identity token on server

What issues does this PR fix or reference?

@W-15428971@

@sfdctaka sfdctaka requested a review from a team as a code owner July 9, 2024 00:39
@maliroteh-sf
Copy link
Contributor

@sfdctaka and @khawkins

In this PR shouldn't we also update PreviewUtils.generateDesktopPreviewLaunchArguments() and PreviewUtils.generateMobileAppPreviewLaunchArguments() to generate something for 0.aura.ldpServerId?

@sfdctaka
Copy link
Contributor Author

sfdctaka commented Jul 9, 2024

@sfdctaka and @khawkins

In this PR shouldn't we also update PreviewUtils.generateDesktopPreviewLaunchArguments() and PreviewUtils.generateMobileAppPreviewLaunchArguments() to generate something for 0.aura.ldpServerId?

Aah. Thought desktopPreview(...) and mobilePreview(...) were going to take the token and do that for 0.aura.ldpServerId. I will add it.

public static generateDesktopPreviewLaunchArguments(
public static async generateDesktopPreviewLaunchArguments(
ldpServerUrl: string,
username: string,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sort of a "one of these things is not like the other", in that the rest of the input parameters are more or less directly plugged into the functions of this method, whereas username is indirectly used as a lookup.

Should we retrieve the Entity ID beforehand, and pass that value in as the input parameter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it would be more consistent to look up Entity ID (in some capacity) in app.ts, somewhere around where the ldpServerUrl is determined.

Copy link
Collaborator

@khawkins khawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my only outstanding comment was the username lookup, but otherwise this all looks fine to me.

@sfdctaka sfdctaka merged commit f435624 into salesforcecli:main Jul 12, 2024
@sfdctaka sfdctaka deleted the newShape branch July 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants