Skip to content

Commit 66429c1

Browse files
committed
remove deprecations in finite_rings
1 parent 9f90540 commit 66429c1

File tree

3 files changed

+0
-81
lines changed

3 files changed

+0
-81
lines changed

src/sage/rings/finite_rings/element_base.pyx

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,30 +24,6 @@ from sage.rings.integer_ring import ZZ
2424
from sage.rings.integer import Integer
2525

2626

27-
def is_FiniteFieldElement(x):
28-
"""
29-
Return ``True`` if ``x`` is a finite field element.
30-
31-
This function is deprecated.
32-
33-
EXAMPLES::
34-
35-
sage: from sage.rings.finite_rings.element_base import is_FiniteFieldElement
36-
sage: is_FiniteFieldElement(1)
37-
doctest:...: DeprecationWarning: the function is_FiniteFieldElement is deprecated; use isinstance(x, sage.structure.element.FieldElement) and x.parent().is_finite() instead
38-
See https://github.com/sagemath/sage/issues/32664 for details.
39-
False
40-
sage: is_FiniteFieldElement(IntegerRing())
41-
False
42-
sage: is_FiniteFieldElement(GF(5)(2))
43-
True
44-
"""
45-
from sage.misc.superseded import deprecation
46-
deprecation(32664, "the function is_FiniteFieldElement is deprecated; use isinstance(x, sage.structure.element.FieldElement) and x.parent().is_finite() instead")
47-
48-
from sage.rings.finite_rings.finite_field_base import FiniteField
49-
return isinstance(x, Element) and isinstance(x.parent(), FiniteField)
50-
5127

5228
cdef class FiniteRingElement(CommutativeRingElement):
5329
def _nth_root_common(self, n, all, algorithm, cunningham):

src/sage/rings/finite_rings/finite_field_base.pyx

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2218,30 +2218,3 @@ def unpickle_FiniteField_prm(_type, order, variable_name, kwargs):
22182218

22192219
register_unpickle_override(
22202220
'sage.rings.ring', 'unpickle_FiniteField_prm', unpickle_FiniteField_prm)
2221-
2222-
2223-
def is_FiniteField(R):
2224-
r"""
2225-
Return whether the implementation of ``R`` has the interface provided by
2226-
the standard finite field implementation.
2227-
2228-
This function is deprecated.
2229-
2230-
EXAMPLES::
2231-
2232-
sage: from sage.rings.finite_rings.finite_field_base import is_FiniteField
2233-
sage: is_FiniteField(GF(9,'a'))
2234-
doctest:...: DeprecationWarning: the function is_FiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) instead
2235-
See https://github.com/sagemath/sage/issues/32664 for details.
2236-
True
2237-
sage: is_FiniteField(GF(next_prime(10^10)))
2238-
True
2239-
2240-
Note that the integers modulo n are not backed by the finite field type::
2241-
2242-
sage: is_FiniteField(Integers(7))
2243-
False
2244-
"""
2245-
from sage.misc.superseded import deprecation
2246-
deprecation(32664, "the function is_FiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) instead")
2247-
return isinstance(R, FiniteField)

src/sage/rings/finite_rings/finite_field_constructor.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -839,34 +839,4 @@ def create_object(self, version, key, **kwds):
839839
GF = FiniteField = FiniteFieldFactory("FiniteField")
840840

841841

842-
def is_PrimeFiniteField(x):
843-
"""
844-
Return ``True`` if ``x`` is a prime finite field.
845-
846-
This function is deprecated.
847-
848-
EXAMPLES::
849-
850-
sage: from sage.rings.finite_rings.finite_field_constructor import is_PrimeFiniteField
851-
sage: is_PrimeFiniteField(QQ)
852-
doctest:...: DeprecationWarning: the function is_PrimeFiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) and x.is_prime_field() instead
853-
See https://github.com/sagemath/sage/issues/32664 for details.
854-
False
855-
sage: is_PrimeFiniteField(GF(7))
856-
True
857-
sage: is_PrimeFiniteField(GF(7^2, 'a'))
858-
False
859-
sage: is_PrimeFiniteField(GF(next_prime(10^90, proof=False)))
860-
True
861-
"""
862-
from sage.misc.superseded import deprecation
863-
deprecation(32664, "the function is_PrimeFiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) and x.is_prime_field() instead")
864-
865-
from .finite_field_prime_modn import FiniteField_prime_modn
866-
from sage.rings.finite_rings.finite_field_base import FiniteField as FiniteField_generic
867-
868-
return isinstance(x, FiniteField_prime_modn) or \
869-
(isinstance(x, FiniteField_generic) and x.degree() == 1)
870-
871-
872842
zech_log_bound = 2**16

0 commit comments

Comments
 (0)