Improve error message for missing trait in trait impl #88894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
r? @estebank |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 3f0e695 has been approved by |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 14, 2021
Improve error message for missing trait in trait impl Fixes rust-lang#88818. For the following example: ```rust struct S { } impl for S { } ``` the current output is: ``` error: missing trait in a trait impl --> t1.rs:2:5 | 2 | impl for S { } | ^ ``` With my changes, I get: ``` error: missing trait in a trait impl --> t1.rs:2:5 | 2 | impl for S { } | ^ | help: add a trait here | 2 | impl Trait for S { } | +++++ help: for an inherent impl, drop this `for` | 2 - impl for S { } 2 + impl S { } | ```
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 14, 2021
Improve error message for missing trait in trait impl Fixes rust-lang#88818. For the following example: ```rust struct S { } impl for S { } ``` the current output is: ``` error: missing trait in a trait impl --> t1.rs:2:5 | 2 | impl for S { } | ^ ``` With my changes, I get: ``` error: missing trait in a trait impl --> t1.rs:2:5 | 2 | impl for S { } | ^ | help: add a trait here | 2 | impl Trait for S { } | +++++ help: for an inherent impl, drop this `for` | 2 - impl for S { } 2 + impl S { } | ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#88033 (Add links for primitives in "jump to definition" feature) - rust-lang#88722 (Make `UnsafeCell::get_mut` const) - rust-lang#88851 (Fix duplicate bounds for const_trait_impl) - rust-lang#88859 (interpreter PointerArithmetic: use new Size helper methods) - rust-lang#88885 (Fix jump def background) - rust-lang#88894 (Improve error message for missing trait in trait impl) - rust-lang#88896 (Reduce possibility of flaky tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88818. For the following example:
the current output is:
With my changes, I get: