Fix invalid link to the C++ Exception Handling ABI documentation #68374
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
tjhu
changed the title
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit d336e59 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
Thanks =) |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 24, 2020
Fix invalid link to the C++ Exception Handling ABI documentation The original link is longer valid(404). I am assuming it's meant to be pointed to the Itanium C++ Exception Handling ABI documentation.
bors
added a commit
that referenced
this pull request
Jan 24, 2020
Rollup of 6 pull requests Successful merges: - #68111 (Print constants in `type_name` for const generics) - #68374 (Fix invalid link to the C++ Exception Handling ABI documentation) - #68504 (Use check-pass mode for lint tests and nll tests) - #68509 (Clean up error codes E0223 and E0225 explanations) - #68511 (Remove unused ignore-license directives) - #68515 (Support feature process_set_argv0 for VxWorks) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original link is longer valid(404). I am assuming it's meant to be pointed to the Itanium C++ Exception Handling ABI documentation.