Skip to content

Add enum keyword #53726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add enum keyword #53726

wants to merge 1 commit into from

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 26, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2018
Centril
Centril reviewed Aug 27, 2018
View reviewed changes
src/libstd/keyword_docs.rs Outdated
Copy link
Contributor

@Centril Centril Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start of sentence "Very.." feels odd.

src/libstd/keyword_docs.rs Outdated
Copy link
Contributor

@Centril Centril Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use the word "variant" instead of "value"; and "see" instead of "get.
So: "To see which variant a value of an enum type is of, you can use pattern matching on the value:"

@TimNN
Copy link
Contributor

TimNN commented Sep 4, 2018

Ping from triage @QuietMisdreavus / @rust-lang/doc: This PR requires your review.

Also ping @GuillaumeGomez: Some changes have already been requested to your PR.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 4, 2018

Updated.

@QuietMisdreavus QuietMisdreavus mentioned this pull request Sep 4, 2018
Closed
@TimNN
Copy link
Contributor

TimNN commented Sep 11, 2018

Ping from triage @QuietMisdreavus / @rust-lang/docs: This PR requires your review.

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Sep 12, 2018

This PR now clashes with #53931, since she's since added docs for enum there. Which do we want to keep?

@Centril
Copy link
Contributor

Centril commented Sep 12, 2018

I would built upon the one in #53931 since it is more elaborate and gives background info.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 12, 2018

Then I'm closing this one.

@GuillaumeGomez GuillaumeGomez deleted the enum-keyword branch September 12, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Centril Centril Centril left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@QuietMisdreavus QuietMisdreavus

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @TimNN @QuietMisdreavus @Centril @rust-highfive