Correct some stability versions #42111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were found by running tidy on stable versions of rust and finding features stabilised with the wrong version numbers.
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| impl_from! { u8, i16, #[stable(feature = "lossless_int_conv", since = "1.5.0")] } | ||
| impl_from! { u8, i32, #[stable(feature = "lossless_int_conv", since = "1.5.0")] } | ||
| impl_from! { u8, i64, #[stable(feature = "lossless_int_conv", since = "1.5.0")] } | ||
| impl_from! { u8, i128, #[unstable(feature = "i128", issue = "35118")] } |
Member
There was a problem hiding this comment.
Is this (and other changes) backwards compatible? I guess you could never use it before either?
Contributor
Author
There was a problem hiding this comment.
Yeah. Stability attributes don't have any effect on impls. The only visible change is in the docs, rustdoc displays the version numbers.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 2f703e4 has been approved by |
Collaborator
|
⌛ Testing commit 2f703e4 with merge 272e77f... |
bors
added a commit
that referenced
this pull request
May 20, 2017
Correct some stability versions These were found by running tidy on stable versions of rust and finding features stabilised with the wrong version numbers.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found by running tidy on stable versions of rust and finding
features stabilised with the wrong version numbers.