Implement AsRef<[T]> for std::slice::Iter.
#35559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
force-pushed
the
slice-iter-as-ref
branch
from
2cecd9a to
9581999
Compare
src/libcore/slice.rs
Outdated
Contributor
There was a problem hiding this comment.
I think you have to make up a new feature name for this, even if it's stable.
frewsxcv
force-pushed
the
slice-iter-as-ref
branch
from
9581999 to
97ee61d
Compare
alexcrichton
added
the
T-libs-api
Member
|
Thanks for the PR @frewsxcv! Could you also expand on the motivation for this as well? |
`AsRef` is designed for conversions that are "cheap" (as per the API docs). It is the case that retrieving the underlying data of `std::slice::Iter` is cheap. In my opinion, there's no ambiguity about what slice data will be returned, otherwise, I would be more cautious about implementing `AsRef`.
frewsxcv
force-pushed
the
slice-iter-as-ref
branch
from
97ee61d to
dc22186
Compare
Contributor
Author
Updated. |
Member
|
Thanks! This libs team discussed this PR during triage yesterday and the decision was to merge. @bors: r+ |
Collaborator
|
📌 Commit dc22186 has been approved by |
Collaborator
|
⌛ Testing commit dc22186 with merge 9376da6... |
bors
added a commit
that referenced
this pull request
Aug 17, 2016
Implement `AsRef<[T]>` for `std::slice::Iter`. `AsRef` is designed for conversions that are "cheap" (as per the API docs). It is the case that retrieving the underlying data of `std::slice::Iter` is cheap. In my opinion, there's no ambiguity about what slice data will be returned, otherwise, I would be more cautious about implementing `AsRef`.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsRefis designed for conversions that are "cheap" (as perthe API docs). It is the case that retrieving the underlying
data of
std::slice::Iteris cheap. In my opinion, there's noambiguity about what slice data will be returned, otherwise,
I would be more cautious about implementing
AsRef.