Skip to content

Conversation

@FuGangqiang
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

r? @steveklabnik

Note that this may not be 100% idiomatic as this is iterating over the Vec<T> by value (e.g. it's calling .into_iter). Often times you may need to write for x in &vec for example.

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Feb 27, 2015
@steveklabnik
Copy link
Contributor

Yes, this should be &vec, r=me wiht that change

@Manishearth
Copy link
Member

@bors: rollup r=steveklabnik

@bors
Copy link
Collaborator

bors commented Feb 28, 2015

@bors r=Manishearth 69bfb6f

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 28, 2015
@bors bors merged commit 69bfb6f into rust-lang:master Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants