Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Nov 12, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

JohnTitor and others added 30 commits October 22, 2025 21:11
async functions are disallowed (because `-> impl Trait` is not supported). `const` entry functions are allowed, nonsecure-call functions must be function pointers, which cannot be evaluated during constant evaluation.
epoll: unblock threads when new interest is registered
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8401398
Filtered ref: 9c097c092eaa8dd786fa7c138a3ecd67b4568d00
Upstream diff: rust-lang/rust@ceb7df7...8401398

This merge was created using https://github.com/rust-lang/josh-sync.
epoll: do proper edge detection inside the epoll system
It has been removed 9 months ago, which is more than a few months.
@Zalathar

This comment was marked as outdated.

@rust-timer

This comment was marked as outdated.

@rust-timer

This comment was marked as outdated.

@Zalathar
Copy link
Member Author

Oh wait, these are all doc profile regressions.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Kobzol
Copy link
Member

Kobzol commented Nov 12, 2025

@rust-timer build d67d57b

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

None of the obvious candidates have reproduced the doc perf regression, so let's try some others.

@rust-timer build 3cf8e1a

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d537e84): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
2.2% [1.1%, 3.5%] 20
Regressions ❌
(secondary)
1.4% [0.2%, 2.8%] 25
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% [-2.9%, 3.5%] 21

Max RSS (memory usage)

Results (primary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Cycles

Results (primary -2.7%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Bootstrap: 476.512s -> 475.767s (-0.16%)
Artifact size: 391.37 MiB -> 391.09 MiB (-0.07%)

bors added a commit that referenced this pull request Nov 13, 2025
Revert "Rollup merge of #146627 - madsmtm:jemalloc-simplify, r=jdonszelmann"

This reverts commit 5dc3c19, reversing
changes made to 11339a0.

Reverts #146627 due to a [perf regression](#148851 (comment)).

r? `@Zalathar`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 14, 2025
Revert "Rollup merge of #146627 - madsmtm:jemalloc-simplify, r=jdonszelmann"

This reverts commit 5dc3c19417d0fbfd979c5a1ecd8bebe2d8d9110e, reversing
changes made to 11339a0ef5ed586bb7ea4f85a9b7287880caac3a.

Reverts rust-lang/rust#146627 due to a [perf regression](rust-lang/rust#148851 (comment)).

r? `@Zalathar`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.