jdonszelmann feedback

Author: hkBst

compiler/rustc_error_codes/src/error_codes/E0608.md

@@ -17,5 +17,9 @@ let v: Vec<u8> = vec![0, 1, 2, 3];
 println!("{}", v[2]);
 ```
 
-Tuples and structs are indexed with dot (`._`), not with brackets (`[_]`).
-Tuple element names are their positions: tuple = (tuple.0, tuple.1, ...)
+Tuples and structs are indexed with dot (`.`), not with brackets (`[]`),
+and tuple element names are their positions:
+```ignore(pseudo code)
+// this (pseudo code) expression is true for any tuple:
+tuple == (tuple.0, tuple.1, ...)
+```

compiler/rustc_hir_typeck/src/expr.rs

@@ -3552,9 +3552,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     );
                     // Try to give some advice about indexing tuples.
                     if let ty::Tuple(types) = base_t.kind() {
-                        err.help(
-                            "tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)",
-                        );
+                        err.help("tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`");
                         // If index is an unsuffixed integer, show the fixed expression:
                         if let ExprKind::Lit(lit) = idx.kind
                             && let ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) = lit.node

tests/ui/indexing/index_message.stderr

@@ -4,7 +4,7 @@ error[E0608]: cannot index into a value of type `({integer},)`
 LL |     let _ = z[0];
    |              ^^^ help: to access tuple element `0`, use: `.0`
    |
-   = help: tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)
+   = help: tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`
 
 error: aborting due to 1 previous error
 

tests/ui/issues/issue-27842.stderr

@@ -4,23 +4,23 @@ error[E0608]: cannot index into a value of type `({integer}, {integer}, {integer
 LL |     let _ = tup[0];
    |                ^^^ help: to access tuple element `0`, use: `.0`
    |
-   = help: tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)
+   = help: tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`
 
 error[E0608]: cannot index into a value of type `({integer}, {integer}, {integer})`
   --> $DIR/issue-27842.rs:9:16
    |
 LL |     let _ = tup[i];
    |                ^^^
    |
-   = help: tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)
+   = help: tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`
 
 error[E0608]: cannot index into a value of type `({integer},)`
   --> $DIR/issue-27842.rs:14:16
    |
 LL |     let _ = tup[3];
    |                ^^^
    |
-   = help: tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)
+   = help: tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`
 
 error: aborting due to 3 previous errors
 

tests/ui/span/suggestion-non-ascii.stderr

@@ -4,7 +4,7 @@ error[E0608]: cannot index into a value of type `({integer},)`
 LL |     println!("☃{}", tup[0]);
    |                        ^^^ help: to access tuple element `0`, use: `.0`
    |
-   = help: tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)
+   = help: tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`
 
 error: aborting due to 1 previous error
 

tests/ui/typeck/coercion-check-for-indexing-expression-issue-40861.stderr

@@ -4,7 +4,7 @@ error[E0608]: cannot index into a value of type `()`
 LL |     ()[f(&[1.0])];
    |       ^^^^^^^^^^^
    |
-   = help: tuples are indexed with dot (`._`): tuple = (tuple.0, tuple.1, ...)
+   = help: tuples are indexed with dot: `tuple == (tuple.0, tuple.1, ...)`
 
 error: aborting due to 1 previous error