Auto merge of #142546 - cjgillot:reachable-jump, r=compiler-errors

Only traverse reachable blocks in JumpThreading.

Fixes #131451

We only compute loop headers for reachable blocks. We shouldn't try to perform an opt on unreachable blocks anyway.

Author: bors

compiler/rustc_mir_transform/src/jump_threading.rs

@@ -89,7 +89,7 @@ impl<'tcx> crate::MirPass<'tcx> for JumpThreading {
             opportunities: Vec::new(),
         };
 
-        for bb in body.basic_blocks.indices() {
+        for (bb, _) in traversal::preorder(body) {
             finder.start_from_switch(bb);
         }
 

tests/crashes/131451.rs renamed to tests/ui/mir/unreachable-loop-jump-threading.rs

@@ -1,9 +1,10 @@
-//@ known-bug: #131451
+//@ build-pass
 //@ needs-rustc-debug-assertions
 //@ compile-flags: -Zmir-enable-passes=+GVN -Zmir-enable-passes=+JumpThreading --crate-type=lib
 
 pub fn fun(terminate: bool) {
     while true {}
+    //~^ WARN denote infinite loops with `loop { ... }`
 
     while !terminate {}
 }

tests/ui/mir/unreachable-loop-jump-threading.stderr

@@ -0,0 +1,10 @@
+warning: denote infinite loops with `loop { ... }`
+  --> $DIR/unreachable-loop-jump-threading.rs:6:5
+   |
+LL |     while true {}
+   |     ^^^^^^^^^^ help: use `loop`
+   |
+   = note: `#[warn(while_true)]` on by default
+
+warning: 1 warning emitted
+