compiler: use is_rustic_abi in ty_utils

expands some conditionals to include different ABIs

Author: workingjubilee

compiler/rustc_ty_utils/src/abi.rs

@@ -436,10 +436,7 @@ fn fn_abi_sanity_check<'tcx>(
     ) {
         let tcx = cx.tcx();
 
-        if spec_abi == ExternAbi::Rust
-            || spec_abi == ExternAbi::RustCall
-            || spec_abi == ExternAbi::RustCold
-        {
+        if spec_abi.is_rustic_abi() {
             if arg.layout.is_zst() {
                 // Casting closures to function pointers depends on ZST closure types being
                 // omitted entirely in the calling convention.
@@ -687,7 +684,7 @@ fn fn_abi_adjust_for_abi<'tcx>(
 
     let tcx = cx.tcx();
 
-    if abi == ExternAbi::Rust || abi == ExternAbi::RustCall || abi == ExternAbi::RustIntrinsic {
+    if abi.is_rustic_abi() {
         fn_abi.adjust_for_rust_abi(cx, abi);
 
         // Look up the deduced parameter attributes for this function, if we have its def ID and

tests/crashes/132981.rs

@@ -0,0 +1,7 @@
+//@compile-flags: -Clink-dead-code=true --crate-type lib
+//@ only-x86_64
+// The set of targets this crashed on was really fiddly, because it was deep in our ABI logic.
+// Basically we didn't handle all "Rusty" ABIs in a uniform way, so we failed to fix up arguments
+// for actually passing through the ABI...
+#![feature(rust_cold_cc)]
+pub extern "rust-cold" fn foo(_: [usize; 3]) {}