Fixed incorrectly marked unsafe functions

Author: vayunbiyani

src/tools/rust-analyzer/crates/hir-ty/src/consteval/tests.rs

@@ -2528,7 +2528,7 @@ fn anonymous_const_block() {
     check_number(
         r#"
     #[rustc_intrinsic]
-    pub unsafe fn size_of<T>() -> usize;
+    pub fn size_of<T>() -> usize;
 
     const fn f<T>() -> usize {
         let r = const { size_of::<T>() };

src/tools/rust-analyzer/crates/hir-ty/src/consteval/tests/intrinsics.rs

@@ -5,7 +5,7 @@ fn size_of() {
     check_number(
         r#"
         #[rustc_intrinsic]
-        pub unsafe fn size_of<T>() -> usize;
+        pub fn size_of<T>() -> usize;
 
         const GOAL: usize = size_of::<i32>();
         "#,
@@ -19,7 +19,7 @@ fn size_of_val() {
         r#"
         //- minicore: coerce_unsized
         #[rustc_intrinsic]
-        pub unsafe fn size_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn size_of_val<T: ?Sized>(_: *const T) -> usize;
 
         struct X(i32, u8);
 
@@ -31,7 +31,7 @@ fn size_of_val() {
         r#"
         //- minicore: coerce_unsized
         #[rustc_intrinsic]
-        pub unsafe fn size_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn size_of_val<T: ?Sized>(_: *const T) -> usize;
 
         const GOAL: usize = {
             let it: &[i32] = &[1, 2, 3];
@@ -46,7 +46,7 @@ fn size_of_val() {
         use core::mem::transmute;
 
         #[rustc_intrinsic]
-        pub unsafe fn size_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn size_of_val<T: ?Sized>(_: *const T) -> usize;
 
         struct X {
             x: i64,
@@ -67,7 +67,7 @@ fn size_of_val() {
         use core::mem::transmute;
 
         #[rustc_intrinsic]
-        pub unsafe fn size_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn size_of_val<T: ?Sized>(_: *const T) -> usize;
 
         struct X {
             x: i32,
@@ -86,7 +86,7 @@ fn size_of_val() {
         r#"
         //- minicore: coerce_unsized, fmt, builtin_impls, dispatch_from_dyn
         #[rustc_intrinsic]
-        pub unsafe fn size_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn size_of_val<T: ?Sized>(_: *const T) -> usize;
 
         const GOAL: usize = {
             let x: &i16 = &5;
@@ -101,7 +101,7 @@ fn size_of_val() {
         r#"
         //- minicore: coerce_unsized
         #[rustc_intrinsic]
-        pub unsafe fn size_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn size_of_val<T: ?Sized>(_: *const T) -> usize;
 
         const GOAL: usize = {
             size_of_val("salam")
@@ -117,7 +117,7 @@ fn min_align_of_val() {
         r#"
         //- minicore: coerce_unsized
         #[rustc_intrinsic]
-        pub unsafe fn min_align_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn min_align_of_val<T: ?Sized>(_: *const T) -> usize;
 
         struct X(i32, u8);
 
@@ -129,7 +129,7 @@ fn min_align_of_val() {
         r#"
         //- minicore: coerce_unsized
         #[rustc_intrinsic]
-        pub unsafe fn min_align_of_val<T: ?Sized>(_: *const T) -> usize;
+        pub fn min_align_of_val<T: ?Sized>(_: *const T) -> usize;
 
         const GOAL: usize = {
             let x: &[i32] = &[1, 2, 3];
@@ -145,7 +145,7 @@ fn type_name() {
     check_str(
         r#"
         #[rustc_intrinsic]
-        pub unsafe fn type_name<T: ?Sized>() -> &'static str;
+        pub fn type_name<T: ?Sized>() -> &'static str;
 
         const GOAL: &str = type_name::<i32>();
         "#,
@@ -154,7 +154,7 @@ fn type_name() {
     check_str(
         r#"
         #[rustc_intrinsic]
-        pub unsafe fn type_name<T: ?Sized>() -> &'static str;
+        pub fn type_name<T: ?Sized>() -> &'static str;
 
         mod mod1 {
             pub mod mod2 {
@@ -173,7 +173,7 @@ fn transmute() {
     check_number(
         r#"
         #[rustc_intrinsic]
-        pub unsafe fn transmute<T, U>(e: T) -> U;
+        pub fn transmute<T, U>(e: T) -> U;
 
         const GOAL: i32 = transmute((1i16, 1i16));
         "#,
@@ -186,9 +186,9 @@ fn read_via_copy() {
     check_number(
         r#"
         #[rustc_intrinsic]
-        pub unsafe fn read_via_copy<T>(e: *const T) -> T;
+        pub fn read_via_copy<T>(e: *const T) -> T;
         #[rustc_intrinsic]
-        pub unsafe fn volatile_load<T>(e: *const T) -> T;
+        pub fn volatile_load<T>(e: *const T) -> T;
 
         const GOAL: i32 = {
             let x = 2;
@@ -385,12 +385,12 @@ fn likely() {
     check_number(
         r#"
         #[rustc_intrinsic]
-        pub const unsafe fn likely(b: bool) -> bool {
+        pub const fn likely(b: bool) -> bool {
             b
         }
 
         #[rustc_intrinsic]
-        pub const unsafe fn unlikely(b: bool) -> bool {
+        pub const fn unlikely(b: bool) -> bool {
             b
         }
 
@@ -719,7 +719,7 @@ fn rotate() {
     check_number(
         r#"
         #[rustc_intrinsic]
-        pub unsafe fn rotate_right<T: Copy>(x: T, y: T) -> T;
+        pub fn rotate_right<T: Copy>(x: T, y: T) -> T;
 
         const GOAL: i32 = rotate_right(10006016, 1020315);
         "#,
@@ -735,7 +735,7 @@ fn simd() {
             i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,
         );
         #[rustc_intrinsic]
-        pub unsafe fn simd_bitmask<T, U>(x: T) -> U;
+        pub fn simd_bitmask<T, U>(x: T) -> U;
         const GOAL: u16 = simd_bitmask(i8x16(
             0, 1, 0, 0, 2, 255, 100, 0, 50, 0, 1, 1, 0, 0, 0, 0
         ));
@@ -748,9 +748,9 @@ fn simd() {
             i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,i8,
         );
         #[rustc_intrinsic]
-        pub unsafe fn simd_lt<T, U>(x: T, y: T) -> U;
+        pub fn simd_lt<T, U>(x: T, y: T) -> U;
         #[rustc_intrinsic]
-        pub unsafe fn simd_bitmask<T, U>(x: T) -> U;
+        pub fn simd_bitmask<T, U>(x: T) -> U;
         const GOAL: u16 = simd_bitmask(simd_lt::<i8x16, i8x16>(
             i8x16(
                 -105, -4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10