Update compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs

chenyukang · estebank · chenyukang · commit 9a6d4140992b · 2025-01-17T08:30:55.000+08:00
Co-authored-by: Esteban Kuber &lt;estebank@users.noreply.github.com&gt;
diff --git a/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs b/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
@@ -789,7 +789,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     }
                 }
                 ExprKind::Path(..) | ExprKind::Lit(_) if parent_is_closure => {
-                    err.span_suggestion(
+                    err.span_suggestion_verbose(
                         expression.span.shrink_to_lo(),
                         "consider ignoring the value",
                         "_ = ",
diff --git a/tests/ui/typeck/closure-ty-mismatch-issue-128561.stderr b/tests/ui/typeck/closure-ty-mismatch-issue-128561.stderr
@@ -2,10 +2,12 @@ error[E0308]: mismatched types
   --> $DIR/closure-ty-mismatch-issue-128561.rs:2:32
    |
 LL |     b"abc".iter().for_each(|x| x);
-   |                                ^
-   |                                |
-   |                                expected `()`, found `&u8`
-   |                                help: consider ignore the value here: `_ =`
+   |                                ^ expected `()`, found `&u8`
+   |
+help: consider ignoring the value
+   |
+LL |     b"abc".iter().for_each(|x| _ = x);
+   |                                +++
 
 error[E0308]: mismatched types
   --> $DIR/closure-ty-mismatch-issue-128561.rs:4:32

Original file line number	Diff line number	Diff line change
`@@ -789,7 +789,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {`
`789`	`789`	`}`
`790`	`790`	`}`
`791`	`791`	`ExprKind::Path(..) \| ExprKind::Lit(_) if parent_is_closure => {`
`792`		`- err.span_suggestion(`
	`792`	`+ err.span_suggestion_verbose(`
`793`	`793`	`expression.span.shrink_to_lo(),`
`794`	`794`	`"consider ignoring the value",`
`795`	`795`	`"_ = ",`