Remove delayed_failures from build and add respective utility methods in execution context for delayed_failures

Author: Shourya742

src/bootstrap/src/lib.rs

@@ -196,7 +196,6 @@ pub struct Build {
     crates: HashMap<String, Crate>,
     crate_paths: HashMap<PathBuf, String>,
     is_sudo: bool,
-    delayed_failures: RefCell<Vec<String>>,
     prerelease_version: Cell<Option<u32>>,
 
     #[cfg(feature = "build-metrics")]
@@ -457,9 +456,7 @@ impl Build {
             crates: HashMap::new(),
             crate_paths: HashMap::new(),
             is_sudo,
-            delayed_failures: RefCell::new(Vec::new()),
             prerelease_version: Cell::new(None),
-
             #[cfg(feature = "build-metrics")]
             metrics: crate::utils::metrics::BuildMetrics::init(),
         };
@@ -698,14 +695,7 @@ impl Build {
         debug!("checking for postponed test failures from `test  --no-fail-fast`");
 
         // Check for postponed failures from `test --no-fail-fast`.
-        let failures = self.delayed_failures.borrow();
-        if !failures.is_empty() {
-            eprintln!("\n{} command(s) did not execute successfully:\n", failures.len());
-            for failure in failures.iter() {
-                eprintln!("  - {failure}\n");
-            }
-            exit!(1);
-        }
+        self.config.exec_ctx().report_failures_and_exit();
 
         #[cfg(feature = "build-metrics")]
         self.metrics.persist(self);

src/bootstrap/src/utils/execution_context.rs

@@ -14,7 +14,7 @@ pub struct ExecutionContext {
     dry_run: DryRun,
     verbose: u8,
     pub fail_fast: bool,
-    pub delayed_failures: Arc<Mutex<Vec<String>>>,
+    delayed_failures: Arc<Mutex<Vec<String>>>,
 }
 
 impl ExecutionContext {
@@ -55,6 +55,22 @@ impl ExecutionContext {
         self.fail_fast = value;
     }
 
+    pub fn add_to_delay_failure(&self, message: String) {
+        self.delayed_failures.lock().unwrap().push(message);
+    }
+
+    pub fn report_failures_and_exit(&self) {
+        let failures = self.delayed_failures.lock().unwrap();
+        if failures.is_empty() {
+            return;
+        }
+        eprintln!("\n{} command(s) did not execute successfully:\n", failures.len());
+        for failure in &*failures {
+            eprintln!("  - {failure}");
+        }
+        exit!(1);
+    }
+
     /// Execute a command and return its output.
     /// Note: Ideally, you should use one of the BootstrapCommand::run* functions to
     /// execute commands. They internally call this method.
@@ -166,8 +182,7 @@ Executed at: {executed_at}"#,
                         fail(&message, output);
                     }
 
-                    let mut failures = self.delayed_failures.lock().unwrap();
-                    failures.push(message);
+                    self.add_to_delay_failure(message);
                 }
                 BehaviorOnFailure::Exit => {
                     fail(&message, output);

src/bootstrap/src/utils/render_tests.rs

@@ -43,8 +43,7 @@ pub(crate) fn try_run_tests(
         if builder.fail_fast {
             crate::exit!(1);
         } else {
-            let mut failures = builder.delayed_failures.borrow_mut();
-            failures.push(format!("{cmd:?}"));
+            builder.config.exec_ctx().add_to_delay_failure(format!("{cmd:?}"));
             false
         }
     } else {