fix some suspicious TypeFolder patterns

Author: arielb1

src/librustc/mir/mod.rs

@@ -1906,12 +1906,18 @@ pub enum Place<'tcx> {
 
 /// The `DefId` of a static, along with its normalized type (which is
 /// stored to avoid requiring normalization when reading MIR).
-#[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Hash, RustcEncodable, RustcDecodable)]
+#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, RustcEncodable, RustcDecodable)]
 pub struct Static<'tcx> {
     pub def_id: DefId,
     pub ty: Ty<'tcx>,
 }
 
+BraceStructTypeFoldableImpl! {
+    impl<'tcx> TypeFoldable<'tcx> for Static<'tcx> {
+        def_id, ty
+    }
+}
+
 impl_stable_hash_for!(struct Static<'tcx> {
     def_id,
     ty
@@ -3285,23 +3291,12 @@ impl<'tcx> TypeFoldable<'tcx> for Terminator<'tcx> {
     }
 }
 
-impl<'tcx> TypeFoldable<'tcx> for Place<'tcx> {
-    // TODO: this doesn't look correct!
-    fn super_fold_with<'gcx: 'tcx, F: TypeFolder<'gcx, 'tcx>>(&self, folder: &mut F)
-                                                              -> Result<Self, F::Error>
-    {
-        match self {
-            &Place::Projection(ref p) => Ok(Place::Projection(p.fold_with(folder)?)),
-            _ => Ok(self.clone()),
-        }
-    }
-
-    fn super_visit_with<V: TypeVisitor<'tcx>>(&self, visitor: &mut V) -> Result<(), V::Error> {
-        if let &Place::Projection(ref p) = self {
-            p.visit_with(visitor)
-        } else {
-            Ok(())
-        }
+EnumTypeFoldableImpl! {
+    impl<'tcx> TypeFoldable<'tcx> for Place<'tcx> {
+        (Place::Local)(local),
+        (Place::Static)(statik),
+        (Place::Promoted)(promoted),
+        (Place::Projection)(projection),
     }
 }
 
@@ -3426,8 +3421,6 @@ where
     }
 }
 
-CloneTypeFoldableImpls! { Field, }
-
 BraceStructTypeFoldableImpl! {
     impl<'tcx> TypeFoldable<'tcx> for Constant<'tcx> {
         span, ty, user_ty, literal

src/librustc/traits/structural_impls.rs

@@ -771,8 +771,8 @@ impl<'tcx, O: TypeFoldable<'tcx>> TypeFoldable<'tcx> for traits::Obligation<'tcx
     }
 
     fn super_visit_with<V: TypeVisitor<'tcx>>(&self, visitor: &mut V) -> Result<(), V::Error> {
-        // TODO: re-add param-env
-        self.predicate.visit_with(visitor)
+        self.predicate.visit_with(visitor)?;
+        self.param_env.visit_with(visitor)
     }
 }
 

src/librustc/ty/structural_impls.rs

@@ -41,6 +41,7 @@ CloneTypeFoldableAndLiftImpls! {
     ::rustc_target::spec::abi::Abi,
     crate::mir::Local,
     crate::mir::Promoted,
+    crate::mir::Field,
     crate::traits::Reveal,
     crate::ty::adjustment::AutoBorrowMutability,
     crate::ty::AdtKind,