fix new clippy warnings

Author: syphar

src/cdn.rs

@@ -179,7 +179,7 @@ mod tests {
                 config.cloudfront_distribution_id_web = Some("distribution_id_web".into());
                 config.cloudfront_distribution_id_static = Some("distribution_id_static".into());
             });
-            invalidate_crate(&*env.config(), &*env.cdn(), "krate")?;
+            invalidate_crate(&env.config(), &env.cdn(), "krate")?;
 
             assert!(matches!(*env.cdn(), CdnBackend::Dummy(_)));
             if let CdnBackend::Dummy(ref invalidation_requests) = *env.cdn() {

src/test/fakes.rs

@@ -303,7 +303,7 @@ impl<'a> FakeRelease<'a> {
                     fs::create_dir_all(&path)
                         .with_context(|| format!("failed to create {}", path.display()))?;
                 }
-                let file = base_path.join(&path);
+                let file = base_path.join(path);
                 debug!("writing file {}", file.display());
                 fs::write(file, data)?;
             }
@@ -422,7 +422,7 @@ impl<'a> FakeRelease<'a> {
             &self.registry_crate_data,
         )?;
         for build in &self.builds {
-            build.create(&mut db.conn(), &*storage, release_id, default_target)?;
+            build.create(&mut db.conn(), &storage, release_id, default_target)?;
         }
         if let Some(coverage) = self.doc_coverage {
             crate::db::add_doc_coverage(&mut db.conn(), release_id, coverage)?;

src/web/page/mod.rs

@@ -35,6 +35,6 @@ mod tera_tests {
             "fa_icon": "https://gph.is/1uOvmqR"
         });
 
-        assert_eq!(correct_json, serde_json::to_value(&alert).unwrap());
+        assert_eq!(correct_json, serde_json::to_value(alert).unwrap());
     }
 }

src/web/sitemap.rs

@@ -213,8 +213,8 @@ mod tests {
             assert!(response.status().is_success());
 
             let content = response.text()?;
-            assert!(content.contains(&"some_random_crate"));
-            assert!(!(content.contains(&"some_random_crate_that_failed")));
+            assert!(content.contains("some_random_crate"));
+            assert!(!(content.contains("some_random_crate_that_failed")));
 
             // and not in the others
             for letter in ('a'..='z').filter(|&c| c != 's') {
@@ -245,7 +245,7 @@ mod tests {
             assert!(response.status().is_success());
 
             let content = response.text()?;
-            assert!(content.contains(&"2022-08-28T00:00:00+00:00"));
+            assert!(content.contains("2022-08-28T00:00:00+00:00"));
             Ok(())
         })
     }

src/web/statics.rs

@@ -231,7 +231,7 @@ mod tests {
                     assert_cache_control(&resp, CachePolicy::ForeverInCdnAndBrowser, &env.config());
                     assert_eq!(
                         resp.bytes()?,
-                        fs::read(&path).unwrap(),
+                        fs::read(path).unwrap(),
                         "failed to fetch {:?}",
                         url,
                     );